Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration group naming conventions and adjustments #271

Closed
91 tasks done
samdark opened this issue Jan 18, 2023 · 4 comments
Closed
91 tasks done

Configuration group naming conventions and adjustments #271

samdark opened this issue Jan 18, 2023 · 4 comments
Assignees
Labels
type:enhancement Enhancement

Comments

@samdark
Copy link
Member

samdark commented Jan 18, 2023

ℹ️ Note that this is not about configuration file names. It is about config groups.

Problem

  • Names do not show what is container config and what are params.
  • There is no naming convention defined.

Solution

  1. Accept/merge "022 - Config groups":
  1. Adjust runners:
  1. Adapt packages to new runners
  1. Adjust group names in existing packages providing configs:
  • commondi
  • webdi-web
  • consoledi-console
  • providers → di-providers
  • providers-web → di-providers-web
  • providers-consoledi-providers-console
  • delegatesdi-delegates
  • delegates-webdi-delegates-web
  • delegates-consoledi-delegates-console
  • tagsdi-tags
  • tags-webdi-tags-web
  • tags-console → di-tags-console

4.1. Create and merge adapt PRs in released packages:

4.2. Create and merge adapt PRs in non-released packages:

4.3. Make releases:

  1. Adapt application templates:
  1. Adapt demo:
  1. Write down short upgrade guides and publish to chats.
@samdark samdark added the type:enhancement Enhancement label Jan 18, 2023
@xepozz
Copy link
Member

xepozz commented Jan 18, 2023

Having container in file/directory names is worse than without it imho

@samdark
Copy link
Member Author

samdark commented Jan 18, 2023

@xepozz updated issue a bit. How about now? (agreements text is in PR linked)

@xepozz
Copy link
Member

xepozz commented Jan 20, 2023

@xepozz updated issue a bit. How about now? (agreements text is in PR linked)

Awful to be honest

This was referenced Feb 5, 2023
This was referenced Feb 10, 2023
@vjik
Copy link
Member

vjik commented Feb 19, 2023

Done 🎉

@vjik vjik closed this as completed Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants