Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters $useBootstrap, $checkEvents and $configGroupPostfix to the HttpApplicationRunner #43

Merged
merged 15 commits into from
Feb 19, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 19, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues yiisoft/app#271

…ix` to the `HttpApplicationRunner`

  constructor
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README should be updated.

@vjik vjik requested review from samdark and a team February 2, 2023 12:22
@vjik vjik added the status:code review The pull request needs review. label Feb 2, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/HttpApplicationRunner.php Outdated Show resolved Hide resolved
src/HttpApplicationRunner.php Outdated Show resolved Hide resolved
src/HttpApplicationRunner.php Outdated Show resolved Hide resolved
src/HttpApplicationRunner.php Outdated Show resolved Hide resolved
src/HttpApplicationRunner.php Outdated Show resolved Hide resolved
src/HttpApplicationRunner.php Outdated Show resolved Hide resolved
vjik and others added 3 commits February 4, 2023 12:57
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@vjik vjik requested a review from samdark February 4, 2023 10:09
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/HttpApplicationRunner.php Outdated Show resolved Hide resolved
src/HttpApplicationRunner.php Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Base: 99.55% // Head: 99.57% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (f25e812) compared to base (046843b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #43      +/-   ##
============================================
+ Coverage     99.55%   99.57%   +0.02%     
  Complexity       75       75              
============================================
  Files             4        4              
  Lines           224      235      +11     
============================================
+ Hits            223      234      +11     
  Misses            1        1              
Impacted Files Coverage Δ
src/HttpApplicationRunner.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik merged commit f93eb0a into master Feb 19, 2023
@vjik vjik deleted the adapt branch February 19, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants