Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt configuration group names to Yii conventions #552

Merged
merged 1 commit into from
Feb 11, 2023
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 11, 2023

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues yiisoft/app#271

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Base: 95.80% // Head: 95.80% // No change to project coverage 👍

Coverage data is based on head (41d773d) compared to base (5448f53).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #552   +/-   ##
=========================================
  Coverage     95.80%   95.80%           
  Complexity      690      690           
=========================================
  Files            85       85           
  Lines          2124     2124           
=========================================
  Hits           2035     2035           
  Misses           89       89           
Impacted Files Coverage Δ
config/di.php 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik requested a review from a team February 11, 2023 14:58
@vjik vjik added the status:code review The pull request needs review. label Feb 11, 2023
@arogachev arogachev merged commit 26fde74 into master Feb 11, 2023
@arogachev arogachev deleted the adapt-configs branch February 11, 2023 16:31
arogachev added a commit that referenced this pull request Feb 11, 2023
arogachev added a commit that referenced this pull request Feb 11, 2023
arogachev added a commit that referenced this pull request Feb 11, 2023
vjik pushed a commit that referenced this pull request Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants