Enh #289: Add validation of renderers configuration to `ViewTrait::withRenderers()` #291

samdark · 2026-01-06T00:03:36Z

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues	#289

…lade.php

codecov · 2026-01-06T00:05:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.51%. Comparing base (455b8e6) to head (320461b).

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #291      +/-   ##
============================================
+ Coverage     99.50%   99.51%   +0.01%     
- Complexity      305      310       +5     
============================================
  Files            19       19              
  Lines           800      822      +22     
============================================
+ Hits            796      818      +22     
  Misses            4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

This PR fixes issue #289 by enabling the view system to properly detect and use template renderers with double file extensions such as "blade.php". Previously, the system only recognized single-part extensions, causing renderers registered with double extensions to not be matched correctly.

Refactored test data provider to use named array keys for better readability
Updated renderer selection logic to match extensions using suffix checking instead of pathinfo
Enhanced template file searching to check registered renderer extensions before fallback extensions

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
tests/ViewTest.php	Refactored test data provider to use named keys, removed unused parameter, and added new test case for double extension rendering
src/ViewTrait.php	Modified renderer selection to use `str_ends_with()` for extension matching and added renderer extension checking in template file search
CHANGELOG.md	Documented the bug fix for double extension support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/ViewTrait.php

tests/ViewTest.php

src/ViewTrait.php

Copilot · 2026-01-06T06:14:00Z

@samdark I've opened a new pull request, #292, to work on those changes. Once the pull request is ready, I'll request review from you.

src/ViewTrait.php

…292) Co-authored-by: samdark <47294+samdark@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: StyleCI Bot <bot@styleci.io>

samdark · 2026-01-06T19:34:45Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-01-06T19:34:53Z

@samdark I've opened a new pull request, #293, to work on those changes. Once the pull request is ready, I'll request review from you.

src/ViewTrait.php

This reverts commit bc901f8.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/ViewTest.php

src/ViewTrait.php

Copilot · 2026-01-12T23:16:39Z

tests/ViewTest.php

+    public function testWithRenderersInvalidRendererTypeThrowsException(): void
+    {
+        $view = TestHelper::createView();
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage(
+            'Render stdClass is not an instance of ' . TemplateRendererInterface::class . '.'
+        );
+
+        $view->withRenderers([
+            'php' => new stdClass(),
+        ]);
+    }


The test only covers the case where an object that doesn't implement TemplateRendererInterface is passed (stdClass). Consider adding test cases for non-object values such as null, strings, arrays, or scalar values to ensure the validation handles these cases correctly and provides meaningful error messages.

@copilot open a new pull request to apply changes based on this feedback

src/ViewTrait.php

Copilot · 2026-01-14T07:59:34Z

@samdark I've opened a new pull request, #296, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: samdark <47294+samdark@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-01-15T23:11:29Z

@samdark I've opened a new pull request, #297, to work on those changes. Once the pull request is ready, I'll request review from you.

Fix #289: Fix template file searching for double extensions such as b…

3f5df73

…lade.php

Copilot AI review requested due to automatic review settings January 6, 2026 00:03

Apply fixes from StyleCI

9fa216f

samdark requested review from Copilot and vjik and removed request for Copilot January 6, 2026 00:03

samdark changed the title ~~Fix #289: Fix template file searching for double extensions such as b…~~ Fix #289: Fix template file searching for double extensions such as blade.php Jan 6, 2026

Copilot started reviewing on behalf of samdark January 6, 2026 00:05 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

src/ViewTrait.php Outdated Show resolved Hide resolved

tests/ViewTest.php Outdated Show resolved Hide resolved

src/ViewTrait.php Outdated Show resolved Hide resolved

Copilot AI mentioned this pull request Jan 6, 2026

Sort renderer extensions by length to prioritize specific extensions #292

Merged

7 tasks

samdark commented Jan 6, 2026

View reviewed changes

src/ViewTrait.php Show resolved Hide resolved

Sort renderer extensions by length to prioritize specific extensions (#…

40a5e9e

…292) Co-authored-by: samdark <47294+samdark@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: StyleCI Bot <bot@styleci.io>

Copilot AI mentioned this pull request Jan 6, 2026

Add performance benchmark for renderer extension matching #293

Closed

Merge branch 'master' into 289-double-extensions

55709e5

vjik requested changes Jan 7, 2026

View reviewed changes

src/ViewTrait.php Outdated Show resolved Hide resolved

src/ViewTrait.php Outdated Show resolved Hide resolved

src/ViewTrait.php Outdated Show resolved Hide resolved

samdark and others added 2 commits January 7, 2026 16:11

Move validation to configuration stage

d723b8c

Apply fixes from StyleCI

813aa5b

samdark requested a review from vjik January 7, 2026 13:12

samdark and others added 3 commits January 7, 2026 13:12

Apply Rector changes (CI)

d82bda7

Merge branch 'master' into 289-double-extensions

58e4451

Move logic away from findTemplateFile()

bc901f8

vjik reviewed Jan 9, 2026

View reviewed changes

src/ViewTrait.php Outdated Show resolved Hide resolved

samdark and others added 3 commits January 9, 2026 17:51

Revert "Move logic away from findTemplateFile()"

52577ff

This reverts commit bc901f8.

Remove unneeded changes

8d31bd6

Apply fixes from StyleCI

5e9e525

Fix test

9f47055

samdark marked this pull request as draft January 9, 2026 21:49

Remove unneeded changes, adjust changelog

048d8e2

samdark changed the title ~~Fix #289: Fix template file searching for double extensions such as blade.php~~ Enh #289: Add validation of renderers configuration to ViewTrait::withRenderers() Jan 12, 2026

samdark marked this pull request as ready for review January 12, 2026 23:12

samdark requested review from Copilot and vjik January 12, 2026 23:12

Copilot started reviewing on behalf of samdark January 12, 2026 23:13 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

vjik mentioned this pull request Jan 13, 2026

ViewRenderer extension #289

Closed

Copilot AI mentioned this pull request Jan 14, 2026

Add validation for non-string keys in ViewTrait::withRenderers() #296

Merged

2 tasks

Copilot AI and others added 4 commits January 16, 2026 02:06

Add validation for non-string keys in ViewTrait::withRenderers() (#296)

880223a

Co-authored-by: samdark <47294+samdark@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Update src/ViewTrait.php

320f83f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply Rector changes (CI)

d1cea9b

Fix error message

320461b

Copilot AI mentioned this pull request Jan 15, 2026

Expand test coverage for renderer type validation to include non-object types #297

Draft

Uh oh!

Enh #289: Add validation of renderers configuration to ViewTrait::withRenderers() #291

Are you sure you want to change the base?

Enh #289: Add validation of renderers configuration to ViewTrait::withRenderers() #291

Uh oh!

Conversation

samdark commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 6, 2026

Uh oh!

Uh oh!

samdark commented Jan 6, 2026

Uh oh!

Copilot AI commented Jan 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

samdark Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Jan 14, 2026

Uh oh!

Copilot AI commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Enh #289: Add validation of renderers configuration to `ViewTrait::withRenderers()` #291

Enh #289: Add validation of renderers configuration to `ViewTrait::withRenderers()` #291

samdark commented Jan 6, 2026 •

edited

Loading

codecov bot commented Jan 6, 2026 •

edited

Loading