Add validation for non-string keys in ViewTrait::withRenderers() #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Address feedback on renderer configuration validation
Add validation for non-string keys in ViewTrait::withRenderers()
Jan 14, 2026
samdark
approved these changes
Jan 14, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds validation to ensure renderer extensions use string keys rather than numeric indices in ViewTrait::withRenderers(). The validation now explicitly checks for non-string keys before other validations, providing a clear error message using get_debug_type().
Changes:
- Added type validation for extension keys to reject numeric indices
- Introduced two test cases covering both implicit and explicit numeric key scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ViewTrait.php | Added string type check for extension keys with descriptive error message |
| tests/ViewTest.php | Added test coverage for implicit and explicit numeric key validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
Member
|
@copilot fix tests. |
Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
Author
Fixed the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 289-double-extensions #296 +/- ##
========================================================
Coverage 99.50% 99.51%
- Complexity 308 309 +1
========================================================
Files 19 19
Lines 814 821 +7
========================================================
+ Hits 810 817 +7
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.