Skip to content

Add validation for non-string keys in ViewTrait::withRenderers() #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samdark merged 4 commits into from
Jan 15, 2026

Fix testImmutability to use string key for renderer

beb2880
Select commit
Loading
Failed to load commit list.
Merged

Add validation for non-string keys in ViewTrait::withRenderers() #296

Fix testImmutability to use string key for renderer
beb2880
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 15, 2026 in 1s

99.51% (+0.00%) compared to 048d8e2

View this Pull Request on Codecov

99.51% (+0.00%) compared to 048d8e2

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.51%. Comparing base (048d8e2) to head (beb2880).

Additional details and impacted files 
@@                   Coverage Diff                    @@
##             289-double-extensions     #296   +/-   ##
========================================================
  Coverage                    99.50%   99.51%           
- Complexity                     308      309    +1     
========================================================
  Files                           19       19           
  Lines                          814      821    +7     
========================================================
+ Hits                           810      817    +7     
  Misses                           4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov