Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Launch script for non python hosts #1016

Merged
merged 3 commits into from
Feb 15, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Feb 12, 2021

Description

Non python hosts Harmony, Photoshop and After Effects are currently launched with python command line commands which won't be possible in Pype 3 as there may not be any pyhton. To be able launch their scripts it is necessary to change launch mechanism and execute python script that start's host implementation.

Changes

  • added script non_python_host_launch.py to "~/pype/scripts/" which is executed by pype's "run" command line command and resolves which launch function is used based on environment variable AVALON_APP
  • individual prelaunch hooks for each host were removed and was added global prelaunch hook for these hosts
    • they should work for both pype from code and build pype

TODOs

  • think about single launch script and prelaunch hook for non python hosts as they are same
  • Test to launch each host from code and build pype
    • Harmony - code
    • Harmony - build
    • Photoshop - code
    • Photoshop - build
    • After Effects - code
    • After Effects - build
🏴 this depends on
avalon-core ynput/avalon-core#280

@iLLiCiTiT iLLiCiTiT self-assigned this Feb 12, 2021
@iLLiCiTiT iLLiCiTiT requested review from kalisp and a team February 12, 2021 16:34
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Feb 12, 2021
@iLLiCiTiT iLLiCiTiT mentioned this pull request Feb 12, 2021
6 tasks
@mkolar
Copy link
Member

mkolar commented Feb 15, 2021

works well on all three hosts. Happy to merge

@mkolar mkolar merged commit 249f533 into develop Feb 15, 2021
@mkolar mkolar added this to the 3.0 milestone Feb 15, 2021
@mkolar
Copy link
Member

mkolar commented Feb 15, 2021

I tested on source and build.

@mkolar mkolar deleted the feature/launch_script_for_non_python_hosts branch February 16, 2021 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants