-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
update houdini menu
update submodules
All occurences of 'pype' database should be replaced with 'openpype'
Added missed ones
Host openpype chasing
Deadline - cleanup, add documentation
Fix Application attribute
Unicode characters causes an issue on specific rendering environments, clean it up for safety.
fix pype references to openpype in ftrack
Fix AD DL comp name
Rename Pype to OpenPype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
./openpype/hosts/nuke/api/utils.py:51:38: B008: Do not perform function calls...
./openpype/hosts/nuke/api/utils.py:51:38: B008: Do not perform function calls in argument defaults. The call is performed only once at function definition time. All calls to your function will reuse the result of that definition-time function call. If this is intended, assign the function call to a module-level variable and use that variable as a default value.
Traceback (most recent call last):
Traceback (most recent call last): File "/home/linters/.local/bin/flake8", line 11, in sys.exit(main()) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/cli.py", line 18, in main app.run(argv) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 393, in run self._run(argv) File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 381, in _run self.run_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/main/application.py", line 300, in run_checks self.file_checker_manager.run() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 331, in run self.run_serial() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 315, in run_serial checker.run_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 598, in run_checks self.run_ast_checks() File "/home/linters/.local/lib/python3.6/site-packages/flake8/checker.py", line 502, in run_ast_checks for (line_number, offset, text, check) in runner: File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 56, in run parser.visit(self.tree) File "/usr/lib/python3.6/ast.py", line 253, in visit return visitor(node) File "/usr/lib/python3.6/ast.py", line 261, in generic_visit self.visit(item) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 39, in visit_ClassDef self.capture_issues_visitor('ClassDef', node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 33, in capture_issues_visitor self.generic_visit(node) File "/usr/lib/python3.6/ast.py", line 263, in generic_visit self.visit(value) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 36, in visit_Call self.capture_issues_visitor('Call', node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checker.py", line 30, in capture_issues_visitor issues = checker.run(node) File "/home/linters/.local/lib/python3.6/site-packages/flake8_django/checkers/render.py", line 22, in run if isinstance(arg, ast.Call) and arg.func.id == 'locals': AttributeError: 'Attribute' object has no attribute 'id'
inside it. If there is none, or it is different from | ||
version specified in file name, skip it. | ||
|
||
Args: | ||
zip_item (Path): Zip file to test. | ||
detected_version (PypeVersion): Pype version detected from name. | ||
detected_version (OpenPypeVersion): Pype version detected from name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (80 > 79 characters)
pype_path = get_pype_path_from_db(location) | ||
if not pype_path: | ||
self._print("cannot find PYPE_PATH in settings.") | ||
pype_path = get_openpype_path_from_db(location) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local variable 'pype_path' is assigned to but never used
zip_path: Path, include_dir: Path, | ||
include_pype: bool = True) -> None: | ||
"""Pack repositories and Pype into zip. | ||
def _create_openpype_zip(self, zip_path: Path, openpype_path: Path) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (80 > 79 characters)
|
||
version = {} | ||
path = Path(os.path.dirname(__file__)).parent / "pype" / "version.py" | ||
path = Path(os.path.dirname(__file__)).parent / "openpype" / "version.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (81 > 79 characters)
<p> | ||
We've detected <b>Pype</b> is not configured yet. But don't worry, | ||
We've detected <b>OpenPype</b> is not configured yet. But don't worry, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (82 > 79 characters)
return None | ||
|
||
@staticmethod | ||
def _get_library_from_container(container: bpy.types.Collection) -> bpy.types.Library: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (90 > 79 characters)
return None | ||
|
||
@staticmethod | ||
def _get_instance_collection(instance_name: str, nodes: List) -> Optional[bpy.types.Collection]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (100 > 79 characters)
if not isinstance(node, bpy.types.Object): | ||
continue | ||
if (node.type == 'EMPTY' and node.instance_type == 'COLLECTION' | ||
and node.instance_collection and node.name == instance_name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (81 > 79 characters)
""" | ||
|
||
@staticmethod | ||
def _get_instance_empty(instance_name: str, nodes: List) -> Optional[bpy.types.Object]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (91 > 79 characters)
CREATE_PATH = os.path.join(PLUGINS_DIR, "create") | ||
INVENTORY_PATH = os.path.join(PLUGINS_DIR, "inventory") | ||
|
||
def install(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expected 2 blank lines, found 1
Implemented Enhancements
Master
versions toHero
versions RenameMaster
versions toHero
versions #1184 @mkolarpype.vendor
OTIO: adding python-2 version topype.vendor
#1222 @jezschaFixed Bugs
Other Changes