Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Minor settings changes #1239

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Minor settings changes #1239

merged 2 commits into from
Apr 1, 2021

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • mutable dict will create new children if is accessed to a key which is not yet available with __getitem__
    • entity["data"]["key"] won't crash if entity is dict-modifiable, it's object type is dictionary entity and "data" was not in settings previously
  • plugin ExtractReview has in Pype 2 tag sequence which is missing in Pype 3

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 31, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 31, 2021 17:53
@mkolar mkolar added the type: bug Something isn't working label Apr 1, 2021
@mkolar mkolar added this to the 3.0.0-beta milestone Apr 1, 2021
@mkolar mkolar merged commit ef7188b into develop Apr 1, 2021
This was referenced Apr 1, 2021
Closed
Closed
@mkolar mkolar deleted the feature/minor_settings_changes branch April 5, 2021 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar