Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Ftrack module refactor #1157

Merged
merged 18 commits into from
Mar 18, 2021
Merged

Ftrack module refactor #1157

merged 18 commits into from
Mar 18, 2021

Conversation

iLLiCiTiT
Copy link
Member

Changes

  • ftrack module should be possible to import and create all the time (Python 2/3 and with/without ftrack_api)
    • removed Python 3 syntax in code which can be used in Python 2 too
    • removed all imports in ftrack module __init__ file that will try to use ftrack_api module
  • class FtrackServer is using file import function from pype.lib (moduke_from_path)
  • imports from ftrack.lib or ftrack.ftrack_server must be explicit
  • moved scripts from ftrack_server folder to scripts folder
  • renamed folders with event handlers
    • actions -> event_handlers_user
    • events -> event_handlers_server
  • replaced usage of CustomDBConnector with PypeMongoConnection
  • abstracted custom ftrack session and updated with newer initialization code

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 18, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 18, 2021 13:48
@mkolar mkolar added backend type: enhancement Enhancements to existing functionality labels Mar 18, 2021
@mkolar mkolar added this to the 3.0.0-beta milestone Mar 18, 2021
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Nuke, Maya and Blender. Publish ok, actions ok, all seem to be fine

@mkolar mkolar merged commit 4f08208 into develop Mar 18, 2021
@mkolar mkolar deleted the feature/ftrack_module_refactor branch March 22, 2021 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants