Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Igniter and Pype bootstrap improvements #1077

Merged
merged 19 commits into from
Mar 10, 2021
Merged

Conversation

antirotor
Copy link
Member

Feature

This refactor functions used to create and install Pype version via Igniter. Including few UI improvements and stopping start.py to load environments from settings until proper Pype version can be determined.

@antirotor antirotor added the type: enhancement Enhancements to existing functionality label Mar 2, 2021
@antirotor antirotor self-assigned this Mar 2, 2021
@rjmoggach
Copy link

On first run would be great to have some more verbosity on documentation/tooltips...
What is the studio root?
What is the repo url?
What is the mongo connection string?
Eg. mongodb+srv://pype:<password>@db.studio.lan/pype

Further to that... (and OT) setting up DNS SRV records is always lovely for mongo

@mkolar
Copy link
Member

mkolar commented Mar 3, 2021

The documentation will come once the beta is out. It was still changing quite a lot until now.

mongo you got right
Repo URL is path to a folder where studio stores zips of pype version for arts

@mkolar mkolar closed this Mar 3, 2021
@mkolar mkolar reopened this Mar 3, 2021
@antirotor
Copy link
Member Author

Added option to run Pype without installation

@antirotor antirotor requested a review from a team March 5, 2021 19:49
@antirotor antirotor marked this pull request as ready for review March 7, 2021 20:14
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Mar 9, 2021

Issues I found out

  • ~/igniter/tools.py function get_pype_path_from_db expect that there is "global_settings" document in mongo
  • directory in built pype "~/<build folder>/lib/" is added to environment PYTHONPATH which breaks all python hosts as it overrides default python modules
  • seems like startup scripts are not executed on host start (didn't look for a reason much)
    • NOTE: We set startup scripts to both avalon and pype paths which does not make sence as what happens in pype's startup should happen on avalon's host installation (which also install pype's host) or we should not start avalon's startup script at all. We should use avalon script or pype script, not both. This is not issue of this PR.

@mkolar mkolar merged commit 68be90e into develop Mar 10, 2021
@mkolar mkolar added this to the 3.0 milestone Mar 10, 2021
@mkolar mkolar deleted the feature/igniter-improvements branch March 12, 2021 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants