This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Sync server fix local drive #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented required methods in LocalDriveHandler Added progress for LocalDriveHandler
local_id is accessible by get_local_site_id, shouldnt be visible in Settings studio and local sites should be configured in Local Settings
refactor renamed get_local_site to get_active_site (part of public API)
, get_remote_sites_from_settings Refactorr
…o sync_server_fix_local_drive
…o sync_server_fix_local_drive
…o sync_server_fix_local_drive
Sites could be configured in Local setting, so validation doesn't have sense here Small refactor
Fix - status for some failed was incorrectly set to Not available Extended AbstracProvider with new method for resolvments of paths Added defaults sites to configured sites Name refactor
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -1334,20 +1421,20 @@ async def sync_loop(self): | |||
| while self.is_running and not self.module.is_paused(): | |||
| import time | |||
| start_time = None | |||
| for collection, preset in self.module.get_synced_presets().\ | |||
| self.module.set_sync_project_settings() # clean cache | |||
| for collection, preset in self.module.get_sync_project_settings().\ | |||
| @@ -849,6 +855,9 @@ def sort(self, index, order): | |||
|
|
|||
| self.sort = {self.SORT_BY_COLUMN[index]: order, '_id': 1} | |||
| self.query = self.get_default_query() | |||
| # import json | |||
| # log.debug(json.dumps(self.query, indent=4).replace('False', 'false').\ | |||
Resolving of path is expensive and not necessary here
…o sync_server_fix_local_drive
'local' should be replaced by local_site_id anytime in real world
mkolar
approved these changes
Mar 12, 2021
This was referenced Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration of using Local Settings
Exposed new methods for Local Settings
Various fixes and refactoring
Contains updates to Local Settings
Currently studio and local sites shouldn't be configurable in Settings. They are pulling root info from Anatomy.
Tested pulling root info from Local settings (for studio and local)