Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Idle manager with separated logic #1147

Merged
merged 7 commits into from
Mar 22, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 17, 2021

Changes

  • logic of idle manager was separated to separate file
    • the logic and python module pynput is imported only when needed
  • renamed file idle_manager.py to idle_module.py
  • fixed multiple callbacks at the same idle time in TimersManager

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 17, 2021
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Mar 17, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 17, 2021 13:53
@mkolar mkolar self-requested a review March 18, 2021 16:44
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timer turns off fine, but no pop up shows. I smell something fishy in here ;)

@iLLiCiTiT
Copy link
Member Author

I smell something fishy in here ;)

Me either. Issue was that it didn't expect multiple callbacks at the same time which may happen only if message time is really small. Fixed...

@mkolar mkolar added this to the 3.0.0-beta milestone Mar 22, 2021
@mkolar mkolar self-requested a review March 22, 2021 08:39
@mkolar mkolar merged commit b994e14 into develop Mar 22, 2021
@mkolar mkolar deleted the feature/idle_manager_with_separated_logic branch March 22, 2021 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants