Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Resolve - loading and updating clips #932

Merged

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Jan 28, 2021

  • loader plugin for loading sequences and video files
  • loading functionality into lib
  • restructure host directory structure
  • testing workflow

@jakubjezek001 jakubjezek001 self-assigned this Jan 28, 2021
@jakubjezek001 jakubjezek001 added type: enhancement Enhancements to existing functionality host: Resolve labels Jan 28, 2021
@jakubjezek001 jakubjezek001 linked an issue Jan 28, 2021 that may be closed by this pull request
@jakubjezek001 jakubjezek001 requested review from a team and removed request for iLLiCiTiT January 28, 2021 10:35
@mkolar mkolar added this to the 3.0 milestone Jan 28, 2021
@jakubjezek001 jakubjezek001 changed the title Resolve - loading and updating - sequence Resolve - loading and updating clips Feb 1, 2021
@mkolar
Copy link
Member

mkolar commented Feb 2, 2021

@jezscha when I try to load an exr sequence, it fails saying it cannot find the file, (pointing to a first frame of the sequence), however coyping that same path from the error log, I can see that the image sequence exists in that exact place. We'll have to check on my setup if I have something different than you probably.

media_pool_item = lib.create_media_pool_item(
self.data["path"], self.active_bin)
clip_property = media_pool_item.GetClipProperty()
clip_name = clip_property["File Name"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local variable 'clip_name' is assigned to but never used

@@ -22,7 +22,7 @@ def process(self, context):
project = resolve.get_current_project()
fps = project.GetSetting("timelineFrameRate")

active_sequence = resolve.get_current_sequence()
active_timeline = resolve.get_current_timeline()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local variable 'active_timeline' is assigned to but never used

otio_timeline, edl_path, adapter_name="cmx_3600")
project = bmdvr.get_current_project()
media_pool = project.GetMediaPool()
timeline = media_pool.ImportTimelineFromFile(edl_path)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local variable 'timeline' is assigned to but never used

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunatelly, the loading itself doesn't work. But this also refactors resolve to 3.0, so I'm merging it and we'll continues working on it in future PRs.

It's a new host, so doesn't affect anything else.

@mkolar mkolar merged commit bab3a2a into develop Feb 16, 2021
@mkolar mkolar deleted the feature/914-dv-resolve-loading-and-updating-image-seqeunce branch February 16, 2021 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Resolve type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DV Resolve - loading and updating - image seqeunce
2 participants