Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Remove Rest Api module #1119

Merged
merged 13 commits into from
Mar 12, 2021
Merged

Remove Rest Api module #1119

merged 13 commits into from
Mar 12, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 12, 2021 •
edited
Loading

Changes

  • removed rest api module and it's usage from all other modules
  • implemented interface IWebServerRoutes for webserver module
    • with this interface it is possible to register routes to webserver
  • all modules that were using rest api module are now using webserver module
    • their implementations were converted and moved to separate files, imported only when used to not break Python 2
  • renamed PYPE_REST_API_URL to PYPE_WEBSERVER_URL

Resolves #651

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 12, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 12, 2021 11:53
@mkolar mkolar added this to the 3.0 milestone Mar 12, 2021
@mkolar mkolar added type: enhancement Enhancements to existing functionality deprecated labels Mar 12, 2021
@mkolar mkolar merged commit d36cdb1 into develop Mar 12, 2021
@iLLiCiTiT iLLiCiTiT mentioned this pull request Mar 12, 2021
Closed
@mkolar mkolar deleted the feature/remove_rest_api_module branch March 12, 2021 16:04
This was referenced Apr 1, 2021
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkolar mkolar mkolar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
deprecated type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
3.0.0-alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar