This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 129
Optionally add task to subset name #1068
Merged
mkolar
merged 37 commits into
develop
from
feature/656-optionally-add-task-to-subset-name
Mar 3, 2021
Merged
Optionally add task to subset name #1068
mkolar
merged 37 commits into
develop
from
feature/656-optionally-add-task-to-subset-name
Mar 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are using pype's cretor
… creates subset name
mkolar
reviewed
Mar 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good. It seems, however, that we're now missing the option to select from already existing subsets in the defaults dropdown menu.
On this occasion. modelMain
already exists and I'm correctly alerted to it, but I should also see Main in the little selection menu on the right. It is there as one of the defaults, but I should also see it below as one of the existing subsets.
Didn't know it's on purpose. Fixed. |
8 tasks
mkolar
approved these changes
Mar 3, 2021
This was referenced Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
families
,hosts
andtask names
family
,task
anduser_input
"{family}{user_input}"
Code changes
avalon-core
Creator
class with methodget_subset_name
pype
PypeCreatorMixin
which should be used as main inherit class (mixin overridesget_subset_name
)Test
render
family creates the same subset name as before these changesResolves: #656