Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Optionally add task to subset name #1068

Merged
merged 37 commits into from
Mar 3, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 1, 2021

Changes

  • added ability to change template of subset name for specific creators by settings
  • templates are resolved by profiled filtering similar to ExtractReview profiles
    • available filtering keys are families, hosts and task names
  • result is template with formattable keys family, task and user_input
    • Example template "{family}{user_input}"

Code changes

avalon-core

  • subset template for creator api is defined by Creator class with method get_subset_name
  • this approach is used in Creator tool

pype

  • in pype is defined PypeCreatorMixin which should be used as main inherit class (mixin overrides get_subset_name)
    • this is because we have to propagate only this method to all creator plugins in pype but they may already inherit from avalon's host creator
    • added Creator class for each pype host if is using avalon host Creator
  • modified standalone publisher to be able use this feature and modified to care about tasks
  • added profile filtering function to pype.lib
  • filter for creators are in project settings under Creator tool
    • has defaults that should work the same way as before

image

Test

  • validate that render family creates the same subset name as before these changes
  • check creator tool in blender
  • check creator tool in harmony
  • check creator tool in maya
  • check creator tool in nuke
  • check creator tool in photoshop
  • check creator tool in aftereffects
  • check creator tool in houdini
  • check creator tool in tvpaint
🏴 this depends on
avalon-core ynput/avalon-core#288
🏴 Pype 2.x PR
pype #1072
avalon-core ynput/avalon-core#289
pype-config ynput/pype-config#101

Resolves: #656

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 1, 2021
@iLLiCiTiT iLLiCiTiT requested a review from a team March 1, 2021 13:59
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good. It seems, however, that we're now missing the option to select from already existing subsets in the defaults dropdown menu.

On this occasion. modelMain already exists and I'm correctly alerted to it, but I should also see Main in the little selection menu on the right. It is there as one of the defaults, but I should also see it below as one of the existing subsets.

image

@iLLiCiTiT
Copy link
Member Author

but I should also see it below as one of the existing subsets.

Didn't know it's on purpose. Fixed.

@iLLiCiTiT iLLiCiTiT mentioned this pull request Mar 2, 2021
8 tasks
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Mar 2, 2021
@mkolar mkolar merged commit af1c39d into develop Mar 3, 2021
@mkolar mkolar deleted the feature/656-optionally-add-task-to-subset-name branch March 12, 2021 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants