Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Optionally add task to subset name #289

Merged
merged 10 commits into from
Mar 3, 2021
Merged

Optionally add task to subset name #289

merged 10 commits into from
Mar 3, 2021

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Mar 2, 2021 •
edited
Loading

Changes

  • subset template for creator api is defined by Creator class with class method get_subset_name
    • the method by default returns what was hardcoded in Creator tool
  • modified how duplicated subset names are checked and already existing subset values are prepared
🏴 this depends on
pype ynput/OpenPype#1072
pype-config ynput/pype-config#101
🏴 Pype 3.x PR
pype ynput/OpenPype#1068
avalon-core #288

@iLLiCiTiT iLLiCiTiT added 2x-dev 2x/develop branch enhancement New feature or request labels Mar 2, 2021
hound[bot]
hound bot reviewed Mar 2, 2021
View reviewed changes
avalon/tools/creator/app.py
# Check if Creator plugin has set defaults
if (
plugin.defaults
and isinstance(plugin.defaults, (list, tuple, set))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line break before binary operator

This was referenced Mar 2, 2021
Merged
Merged
Merged
Merged
@mkolar mkolar merged commit 5f9eb03 into 2.x/develop Mar 3, 2021
@mkolar mkolar deleted the feature/2_0_656-optionally-add-task-to-subset-name branch October 14, 2021 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hound hound[bot] hound[bot] left review comments

Assignees
No one assigned
Labels
2x-dev 2x/develop branch enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @mkolar