This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Settings list race condifiton and mutable dict list conversion #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antirotor
approved these changes
Jun 9, 2021
kalisp
added a commit
that referenced
this pull request
Jun 9, 2021
#1671 PR fixed issue that limited of usage of multiline previously
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
add_rowmay cause that settings ui will crash because of recursion error because it's children value change may trigger adding infinite children with same valueDictMutableKeysDictis still broken because of missing conversion to list invaluepropertyChanges
set_entity_valueon ListWidget'sadd_rowafter new item is part ofinput_fieldsvalueinDictMutableKeysDictis append list of key, value