Timers manager: Get task time #1896
Conversation
tokejepsen
added
type: enhancement
# Conflicts: # openpype/modules/default_modules/ftrack/ftrack_module.py
|
Do not change avalon-core commit in OpenPype PRs please. |
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
# Conflicts: # repos/avalon-core
Sorry about that. All fixed now. |
| @@ -105,6 +105,15 @@ def start_timer(self, project_name, asset_name, task_name, hierarchy): | |||
| } | |||
| self.timer_started(None, data) | |||
|
|
|||
| def get_task_time(self, project_name, asset_name, task_name): | |||
There was a problem hiding this comment.
If get_task_time method is expected from a module (even if is optional) then should be defined in ITimersManager (inside ~/openpype/modules/default_modules/timers_manager/interfaces.py). Ideally if is optional then return None in default implementation so it is possible to check return value and skip all None values here...
EDITED:
Since PR #2024 timers manager does not have ITimersManager and also does not have attribute modules. Instead of that has _connectors_by_module_id so the loop should look like:
times = {}
for module_id, connector in self._connectors_by_module_id.items():
if hasattr(connector, "get_task_time"):
module = self._modules_by_id[module_id]
times[module.name] = connector.get_task_time(
project_name, asset_name, task_name
)
return times
|
@iLLiCiTiT @tokejepsen could we please resolve the conflict? happy to merge then |
# Conflicts: # openpype/modules/default_modules/ftrack/ftrack_module.py
Done |
This PR adds a method for querying the task time from all modules registered.
Currently only Ftrack has the method implemented, because I cant find any docs for setting up the Clockify api. This means currently it'll fail when using Clockify.