TimersManager: Removed interface of timers manager #2024

iLLiCiTiT · 2021-09-15T09:46:42Z

Goal

TimersManager does not use interface to connect with other modules
module must have defined timers_manager_connector attribute which has at least 2 methods stop_timer and start_timer
ftrack and clockify modules were modified to have that attribute and methods

…h methods

… predefined methods

antirotor

looks ok and it doesn't crash anything. No idea how to test it more :)

iLLiCiTiT added 6 commits September 15, 2021 11:19

removed interface of timers manager

d600bfb

TimersManager has new way of connection definition to it's logic

292655e

modified timer stopped/started methods

412d429

added example of connector to timers manager

2647b3f

modified clickify to not use ITimersManager but defined attribute wit…

15a8c47

…h methods

modified ftrack to not use ITimersManager but defined attributes with…

3704b0c

… predefined methods

iLLiCiTiT self-assigned this Sep 15, 2021

iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Sep 15, 2021

iLLiCiTiT requested review from kalisp and antirotor September 15, 2021 09:46

iLLiCiTiT mentioned this pull request Sep 15, 2021

OpenPype modules/addons without interfaces #2023

Closed

4 tasks

antirotor approved these changes Sep 20, 2021

View reviewed changes

Merge branch 'develop' into feature/timers_manager_wihtout_interface

a447879

iLLiCiTiT merged commit 54a273e into develop Sep 20, 2021

iLLiCiTiT mentioned this pull request Sep 20, 2021

Timers manager: Get task time #1896

Merged

iLLiCiTiT deleted the feature/timers_manager_wihtout_interface branch December 13, 2021 15:37