Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Ftrack: Use client query functions #3339

Merged
merged 18 commits into from
Jun 21, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Jun 14, 2022

Brief description

Ftrack module is using query functions from PR instead of direct use of mongo queries.

Description

Replaced queries using AvalonMongoDB with using function queries from openpype.client. Function get_versions can accept version names (versions as integers) in filter args. Added new function get_archived_assets, it is questionable if it can be merged into get_assets with more specific arguments.

Testing notes:

  • Run any application
  • Run prepare project action on new project
  • Auto-sync from ftrack should work (event server must be running)
  • Run sync to avalon action (doesn't matter if local of server)
  • Download thumbnails from ftrack to openpype
  • Run delivery action
  • Run delete old versions action
  • Run delete asset/subset action (it would be good to try both variants)
  • Integration of hierarchy to ftrack during editorial publishing
  • Action to fill workfile attribute (this requires some more settings)

Optional testing

Not sure if these features were working:

  • Event user assignment
  • RV action

@ynbot
Copy link
Contributor

ynbot commented Jun 14, 2022

Task linked: OP-3407 Use query functions in ftrack

@iLLiCiTiT iLLiCiTiT self-assigned this Jun 14, 2022
@iLLiCiTiT iLLiCiTiT added module: Ftrack type: refactor Structural changes not affecting functionality labels Jun 14, 2022
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during Delivery action on AssetVersions, following issue had occured @iLLiCiTiT

Traceback (most recent call last):
  File "C:\CODE\__PYPE\OpenPype\openpype\modules\ftrack\event_handlers_user\action_delivery.py", line 478, in launch
    report = self.real_launch(session, entities, event)
  File "C:\CODE\__PYPE\OpenPype\openpype\modules\ftrack\event_handlers_user\action_delivery.py", line 545, in real_launch
    version_ids = self._get_interest_version_ids(session, entities)
TypeERROR: _get_interest_version_ids() missing 1 required positional argument: 'entities'

@jakubjezek001
Copy link
Member

Also, if I select any asset/shot and chose Delete Asset/Subset action, it is ignoring the context where it is started from and behaving like I am in Project context. It is listing all available Asset objects within the project.

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I was testing was working well and I have ticked ON tested features.

@iLLiCiTiT iLLiCiTiT merged commit 3ecbeb1 into develop Jun 21, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3407_Use-query-functions-in-ftrack branch June 21, 2022 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
module: Ftrack type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants