This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
General: Define query functions #3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-3292 Map where database queries and changes |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| ) | ||
| from openpype.pipeline import HeroVersionType | ||
| from .models import TreeModel | ||
| from . import lib |
There was a problem hiding this comment.
module level import not at top of file
| get_hero_versions, | ||
| ) | ||
| from openpype.pipeline import HeroVersionType | ||
| from .models import TreeModel |
There was a problem hiding this comment.
module level import not at top of file
| get_versions, | ||
| get_hero_versions, | ||
| ) | ||
| from openpype.pipeline import HeroVersionType |
There was a problem hiding this comment.
module level import not at top of file
| if Qt.__binding__ == "PySide": | ||
| from PySide.QtGui import QStyleOptionViewItemV4 | ||
| elif Qt.__binding__ == "PyQt4": | ||
| from PyQt4.QtGui import QStyleOptionViewItemV4 | ||
|
|
||
| from openpype.client import ( |
There was a problem hiding this comment.
module level import not at top of file
…rsion_by_subset_id'
…id' and 'get_last_version_by_subset_name'
|
I'll just add that this is part of the continuous work towards a properly defined V4 API on the client side as well as server. To be able to make the move, we first need to unify what's going on with the DB call across the codebase. |
mkolar
suggested changes
Jun 8, 2022
|
Should work now |
| - versions | ||
|
|
||
| ### Standalone publisher | ||
| - openpype/hosts/standalonepublisher/plugins/publish/collect_bulk_mov_instances.py |
antirotor
approved these changes
Jun 13, 2022
This was referenced Jun 13, 2022
kalisp
approved these changes
Jun 14, 2022
iLLiCiTiT
deleted the
feature/OP-3292_Map-where-database-queries-and-changes
branch
This was referenced Jun 14, 2022
This was referenced Jun 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Define basic query functions to replace direct mongo queries for project specific entities.
Description
We need to define functions that will cover all direct mongo queries in code and use only functions in a way that functions logic can be changed to work with any other database system, or at least as much as possible. This is first step of the change by defying basic query functions which are used (for now) only in tools.
AvalonMongoDBobjects andlegacy_iohave new functionsactive_projectandcurrent_project(difference is thatcurrent_projectdoes not require installation).Additional information
At this stage all tools should work as they did. Content of
openpype.clientmust be self contained so there is no place to useany other context then context passed to functions which are called there.
Some functions can be split into more, some functions can be merged into one, some are missing completely because there was not a use case for them in tools.
Future goals
openpype.libtoopenpype.client(with backwards compatibility).Testing notes: