This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
AfterEffects: Use client query functions #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-3376 Use query functions in AfterEffects |
iLLiCiTiT
added
host: After Effects
type: refactor
64qam
approved these changes
Jun 21, 2022
iLLiCiTiT
deleted the
feature/OP-3376_Use-query-functions-in-AfterEffects
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Modified AfterEffects host to use query functions from PR.
Description
AfterEffects is using query functions from
openpype.clientto get assets. Functionget_asset_settingsexpects asset document to be passed.Question
Function
get_asset_settingsis used only in pluginValidateSceneSettingswhich always used asset from current context to get expected data which does not seem to make much sense? Shouldn't that plugin be context plugins instead of instance plugin? Or should it pass asset document from context data instead of instance data? Not sure if is possible to have multiple instances for different assets in afters...Testing notes:
Workfile creator
Validator