公開投稿以外の配送を制限する機能 #574
Merged
公開投稿以外の配送を制限する機能 #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
packages/frontend
packages/cherrypick-js
labels
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }; | ||
| })), JSON.stringify(Array.from(expected).reverse())); | ||
| }); | ||
| //FIXME: assert.rejectsがundefinedを返す |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test
penginn-net
reviewed
Jan 11, 2025
| await assert.rejects( | ||
| async () => await bob.client.request('notes/reactions/create', { noteId: resolvedNote.id, reaction: '😅' }), | ||
| (err: any) => { | ||
| strictEqual(err.code, 'YOU_HAVE_BEEN_BLOCKED'); |
There was a problem hiding this comment.
Suggested change
| strictEqual(err.code, 'YOU_HAVE_BEEN_BLOCKED'); | |
| strictEqual(err.error.code, 'YOU_HAVE_BEEN_BLOCKED'); |
もだめ？
|
なんでおちるんだろこれ |
|
|
|
Thank you for sending us a great Pull Request! 👍 example: pnpm run build-cherrypick-js-with-types |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
publicとhome以外のnoteとrenoteを配送しない機能を追加
Why
resolve: #349
Additional info (optional)
ダイレクトは通しても良いかも？
通常投稿以外は対象にしてないけど他に非公開な要素あったっけ？
Checklist