-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to name executable target in schemes Run
configuration.
#869
Added ability to name executable target in schemes Run
configuration.
#869
Conversation
Run
configuration.
Does this also provide the option to set the executable to "Ask on Launch"? |
@pinda unfortunately it does not. Sadly I do not have the bandwidth to look into this this week. |
No worries, created my own separate PR |
@@ -114,9 +114,11 @@ public struct Scheme: Equatable { | |||
public var launchAutomaticallySubstyle: String? | |||
public var debugEnabled: Bool | |||
public var simulateLocation: SimulateLocation? | |||
public var executableName: String? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the property from the Build
struct as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it's still there up on line 76?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brentleyjones @elland When running tests on the CI I get the following error when I used xcodegen
build from te latest master
branch.
xcodebuild: error: The scheme 'MyTests' is not configured for Running.
--
08-Jun-2020 16:53:55 | The scheme 'MyTests' has nothing configured to build for Running and has no executable specified to Run. Edit the scheme to configure the Run action.
I believe the issue is caused by this change, because the previous release of xcodegen (0.15.1) works well for me.
I don't have an idea how to fix that. Do you now how to have the previous functionality working and changes that @elland introduced?
b99ea56
to
442a3cf
Compare
Run
configuration.Run
configuration.
``` schemes: MyScheme: build: executable: MyExecutable targets: ... ```
503d03e
to
46d3de0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @elland for fixing this!
@@ -356,6 +355,7 @@ extension Scheme.Run: JSONObjectConvertible { | |||
region = jsonDictionary.json(atKeyPath: "region") | |||
debugEnabled = jsonDictionary.json(atKeyPath: "debugEnabled") ?? Scheme.Run.debugEnabledDefault | |||
simulateLocation = jsonDictionary.json(atKeyPath: "simulateLocation") | |||
executableName = jsonDictionary.json(atKeyPath: "executable") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👆 @yonaskolb there is a wrong name used in the docs it should be executable
not executableName
No description provided.