Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to name executable target in schemes Run configuration. #869

Merged

Conversation

elland
Copy link
Contributor

@elland elland commented May 25, 2020

No description provided.

@elland elland changed the title Added ability to name executable target in schemes configuration. Fix: Added ability to name executable target in schemes Run configuration. May 25, 2020
@pinda
Copy link
Contributor

pinda commented May 26, 2020

Does this also provide the option to set the executable to "Ask on Launch"?

@elland
Copy link
Contributor Author

elland commented May 26, 2020

@pinda unfortunately it does not. Sadly I do not have the bandwidth to look into this this week.

@pinda
Copy link
Contributor

pinda commented May 26, 2020

No worries, created my own separate PR

@@ -114,9 +114,11 @@ public struct Scheme: Equatable {
public var launchAutomaticallySubstyle: String?
public var debugEnabled: Bool
public var simulateLocation: SimulateLocation?
public var executableName: String?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the property from the Build struct as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's still there up on line 76?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brentleyjones @elland When running tests on the CI I get the following error when I used xcodegen build from te latest master branch.

xcodebuild: error: The scheme 'MyTests' is not configured for Running.
--
08-Jun-2020 16:53:55 | The scheme 'MyTests' has nothing configured to build for Running and has no executable specified to Run. Edit the scheme to configure the Run action.

I believe the issue is caused by this change, because the previous release of xcodegen (0.15.1) works well for me.

I don't have an idea how to fix that. Do you now how to have the previous functionality working and changes that @elland introduced?

@elland elland force-pushed the feature/name-executable-in-scheme branch 3 times, most recently from b99ea56 to 442a3cf Compare May 26, 2020 13:52
@elland elland changed the title Fix: Added ability to name executable target in schemes Run configuration. Added ability to name executable target in schemes Run configuration. May 26, 2020
@elland elland requested a review from brentleyjones May 27, 2020 08:40
```
schemes:
  MyScheme:
    build:
      executable: MyExecutable
      targets:
      ...
```
@elland elland force-pushed the feature/name-executable-in-scheme branch from 503d03e to 46d3de0 Compare May 28, 2020 07:24
Copy link
Collaborator

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elland for fixing this!

@brentleyjones brentleyjones merged commit 463db06 into yonaskolb:master May 28, 2020
@elland elland deleted the feature/name-executable-in-scheme branch May 28, 2020 13:26
@yonaskolb
Copy link
Owner

Thanks @elland. I've also just added the new property to the docs fd7a6d3

@@ -356,6 +355,7 @@ extension Scheme.Run: JSONObjectConvertible {
region = jsonDictionary.json(atKeyPath: "region")
debugEnabled = jsonDictionary.json(atKeyPath: "debugEnabled") ?? Scheme.Run.debugEnabledDefault
simulateLocation = jsonDictionary.json(atKeyPath: "simulateLocation")
executableName = jsonDictionary.json(atKeyPath: "executable")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆 @yonaskolb there is a wrong name used in the docs it should be executable not executableName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants