Sync android-sdk with js-sdk: Implement updates to v0.4.27 #212

daeyounglnc · 2024-08-28T13:28:59Z

What this PR does / why we need it?

Applied changes from JS SDK up to 0.4.27.
Not all tasks are complete, so I make the list of tasks below.

0.4.27

0.4.26

0.4.25

Any background context you want to provide?

Didn't proceed with tasks that it seems doesn't need to take. (e.g., working with JS documentation)
It seem to be difficult to do with the current version of connectRpc. We need to find another workaround. Handle ErrClientNotActivated and ErrClientNotFound yorkie-js-sdk#865

What are the relevant tickets?

It wasn't limited to just a single task or PR.
Please check below releases, this PR included tasks from versions 0.4.25 through 0.4.27.
https://github.com/yorkie-team/yorkie-js-sdk/releases

Fixes #

Checklist

Added relevant tests or not required
Didn't break anything

…ception

coderabbitai · 2024-08-28T13:29:08Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

daeyounglnc · 2024-08-29T06:23:19Z

gradle.properties

@@ -11,7 +11,7 @@ android.suppressUnsupportedOptionWarnings=android.suppressUnsupportedOptionWarni
 kotlin.code.style=official
 kotlin.mpp.stability.nowarn=true
 GROUP=dev.yorkie
-VERSION_NAME=0.4.25-rc
+VERSION_NAME=0.4.27-rc


I set the RC version because even after the merge this PR, there are still specs to discuss.
yorkie-team/yorkie-js-sdk#865

daeyounglnc · 2024-08-29T06:33:35Z

yorkie/src/androidTest/kotlin/dev/yorkie/core/ClientTest.kt

+            c1.syncAsync().await()
+
+            // 02. c2 receives the snapshot and increases the counter simultaneously.
+            // The tc in js-sdk, it performed the sync before update, but it is not necessary.


@raararaara ,

As we talked in the offline conversation, calling the sync function in the js-sdk isn't mandatory.
So I didn't write the code to call the sync (syncAsync in android) function, I thought it might cause unnecessary to understand exactly what TC is trying to do.
If you has any thoughts on this, please comment.

daeyounglnc · 2024-08-29T06:42:39Z

yorkie/src/androidTest/kotlin/dev/yorkie/core/DocumentTest.kt

@@ -621,4 +623,215 @@ class DocumentTest {
            collectJobs.values.forEach(Job::cancel)
        }
    }
+
+    @Test
+    fun test_single_document_event_stream_can_emit_document_status_changed() {


We doesn't implement this behavior before, but I added this for more detailed validation, I think.

yorkie/src/main/kotlin/dev/yorkie/core/Client.kt

yorkie/src/main/kotlin/dev/yorkie/document/crdt/CrdtText.kt

yorkie/src/main/kotlin/dev/yorkie/document/json/JsonText.kt

yorkie/src/main/kotlin/dev/yorkie/util/ConnectRpcErrorUtil.kt

yorkie/src/main/kotlin/dev/yorkie/util/YorkieException.kt

Co-authored-by: Hyowoo Kim <skhugh@gmail.com>

…f-block

yorkie/src/main/kotlin/dev/yorkie/core/Client.kt

yorkie/src/main/kotlin/dev/yorkie/document/Document.kt

yorkie/src/main/kotlin/dev/yorkie/util/ConnectRpcErrorUtil.kt

yorkie/src/test/kotlin/dev/yorkie/document/DocumentTest.kt

yorkie/src/main/kotlin/dev/yorkie/util/ConnectRpcErrorUtil.kt

7hong13 · 2024-09-02T12:11:29Z

yorkie/src/androidTest/kotlin/dev/yorkie/core/DocumentTest.kt

+            val document2StatusChangedList = mutableListOf<Event.DocumentStatusChanged>()
+            val jobs = mapOf(
+                "document1 status changed events" to launch(start = CoroutineStart.UNDISPATCHED) {
+                    document1.events.filterIsInstance<Event.DocumentStatusChanged>()


just a trivial question, but is there any reason to use a Map instead of a List? It seems like you're not using the keys.

I didn't intend to use Map for anything else.
Actually, as your comment, there was no need to use Map in another function.
Also, some functions I've written don't need Map. Maybe it's better to use List.
but I think it makes sense for naming purposes, so I'll keep it as it is for now.

- And actorID will not pass if status is not attached type.

daeyounglnc added 16 commits August 15, 2024 06:07

Publish DocumentStatusChanged event if status was changed

1a279a5

Remove node from indexes during GC

8b92b71

Handle retry for syncLoop and watchLoop

726e57a

Updated lambda parameter's name

44ce553

Added tc for the condition of watchLoop.

9af7217

Defined YorkieException to handle error by type

c6ae388

Replace other exceptions and Kotlin's check()/require() with YorkieEx…

56c97d9

…ception

Added a tc to verify correct usage of YorkieException and Code

657782f

Removed comment

97322ad

Updated docker-compose.yml and docker-compose-ci.yml

7713dd4

Fixes issues caused by not using little endian

c74ac17

Handle local changes correctly when receiving snapshot

d26d565

Updated version to 0.4.27-rc

0555d69

Use little endian in MockYorkieService

b1970e3

Use little endian on CrdtPrimitive.kt

80df75c

Bump up libraries

4a58b48

daeyounglnc requested review from skhugh and 7hong13 August 28, 2024 13:28

daeyounglnc self-assigned this Aug 28, 2024

daeyounglnc changed the title ~~Sync Android SDK with JS SDK: Implement Updates to v0.4.27~~ Sync android-sdk with js-sdk: Implement updates to v0.4.27 Aug 29, 2024

daeyounglnc commented Aug 29, 2024

View reviewed changes

Update tc to represent the changed spec.

74fe3be

daeyounglnc commented Aug 29, 2024

View reviewed changes

Removed unused function

6f98ad6

skhugh reviewed Aug 29, 2024

View reviewed changes

daeyounglnc and others added 3 commits September 1, 2024 03:00

Added access modifier

6966671

Co-authored-by: Hyowoo Kim <skhugh@gmail.com>

Added access modifier

a7166d3

Co-authored-by: Hyowoo Kim <skhugh@gmail.com>

Added access modifier

698e0ec

Co-authored-by: Hyowoo Kim <skhugh@gmail.com>

daeyounglnc and others added 8 commits September 1, 2024 03:04

fixed a typo

6c6e41b

Updated comment

3524c6b

Modified property's name

0aaa758

Co-authored-by: Hyowoo Kim <skhugh@gmail.com>

Modified property's name

10dea5e

Co-authored-by: Hyowoo Kim <skhugh@gmail.com>

Added access modifier

64c55bc

Added access modifier

a0abc7a

Updated tc to fix compile error

cbd8272

Calling handleWatchStreamFailure() function was moved to outside of i…

e1f6de8

…f-block

7hong13 reviewed Sep 2, 2024

View reviewed changes

daeyounglnc added 6 commits September 12, 2024 19:16

Removed unnecessary Map to make the code a bit clearer.

f0bd230

Improve code readability

d30bbfc

Removed unused logs

ba2229f

Updated comment

12aa5ef

Improved comment

45f1c71

Removed actorID parameter from applyDocumentStatus() function.

358c8ac

- And actorID will not pass if status is not attached type.

7hong13 approved these changes Sep 13, 2024

View reviewed changes

daeyounglnc merged commit a5a62a5 into yorkie-team:v0.4.27 Sep 24, 2024
1 check passed

daeyounglnc mentioned this pull request Nov 20, 2024

Handle ErrClientNotActivated and ErrClientNotFound #213

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sync android-sdk with js-sdk: Implement updates to v0.4.27 #212

Sync android-sdk with js-sdk: Implement updates to v0.4.27 #212

daeyounglnc commented Aug 28, 2024 •

edited

Loading

coderabbitai bot commented Aug 28, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

daeyounglnc Aug 29, 2024

daeyounglnc Aug 29, 2024 •

edited

Loading

daeyounglnc Aug 29, 2024 •

edited

Loading

7hong13 Sep 2, 2024 •

edited

Loading

daeyounglnc Sep 12, 2024 •

edited

Loading

Sync android-sdk with js-sdk: Implement updates to v0.4.27 #212

Sync android-sdk with js-sdk: Implement updates to v0.4.27 #212

Conversation

daeyounglnc commented Aug 28, 2024 • edited Loading

What this PR does / why we need it?

Any background context you want to provide?

What are the relevant tickets?

Checklist

coderabbitai bot commented Aug 28, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

daeyounglnc Aug 29, 2024

Choose a reason for hiding this comment

daeyounglnc Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

daeyounglnc Aug 29, 2024 • edited Loading

Choose a reason for hiding this comment

7hong13 Sep 2, 2024 • edited Loading

Choose a reason for hiding this comment

daeyounglnc Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

daeyounglnc commented Aug 28, 2024 •

edited

Loading

coderabbitai bot commented Aug 28, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

daeyounglnc Aug 29, 2024 •

edited

Loading

daeyounglnc Aug 29, 2024 •

edited

Loading

7hong13 Sep 2, 2024 •

edited

Loading

daeyounglnc Sep 12, 2024 •

edited

Loading