-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use module import style for Protobuf #853
Conversation
This commit switchs Protobuf build to use js_import_style=module. This change is possible due to migration from Webpack to Vite.
Warning Review failedThe pull request is closed. WalkthroughThe recent changes shift the JavaScript import style from Changes
No sequence diagrams will be provided due to the nature of the changes, which are primarily syntactical without altering control flow or adding new features. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 80.68% 80.61% -0.07%
==========================================
Files 59 60 +1
Lines 4586 4565 -21
Branches 932 932
==========================================
- Hits 3700 3680 -20
+ Misses 617 616 -1
Partials 269 269 ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it?
Use module import style for Protobuf
This commit switches Protobuf build to use
js_import_style=module
.This change is possible due to migration from
benchmark.js
tovitest
.Any background context you want to provide?
What are the relevant tickets?
Related to
benchmark.js
withvitest bench
#793Checklist
Summary by CodeRabbit
New Features
Improvements
require
toimport
statements across the codebase for better readability and maintainability.export
statements, improving module interoperability.