-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Protocol Changes for Tree.RemoveStyle #755
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
+ Coverage 81.50% 81.77% +0.26%
==========================================
Files 59 59
Lines 4348 4357 +9
Branches 853 856 +3
==========================================
+ Hits 3544 3563 +19
+ Misses 543 537 -6
+ Partials 261 257 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raararaara Is there no need to add related test codes?
Please also add a brief explanation.
What this PR does / why we need it?
Any background context you want to provide?
What are the relevant tickets?
Related #745, yorkie-team/yorkie#748
I have added the relavent test code and added a brief explanation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What this PR does / why we need it?
This PR reflects protocol changes for the Tree.RemoveStyle patch on #745.
Any background context you want to provide?
What are the relevant tickets?
Related #745, yorkie-team/yorkie#748
Checklist