Implement Tree.RemoveStyle #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hackerwins
reviewed
Jan 5, 2024
justiceHui
force-pushed
the
tree-remove-style
branch
from
e38d78f to
5e1df21
Compare
2 tasks
justiceHui
force-pushed
the
tree-remove-style
branch
from
4f7720f to
77107e4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
==========================================
+ Coverage 49.48% 50.00% +0.51%
==========================================
Files 69 69
Lines 10099 10224 +125
==========================================
+ Hits 4997 5112 +115
+ Misses 4587 4570 -17
- Partials 515 542 +27 ☔ View full report in Codecov by Sentry. |
justiceHui
changed the title
hackerwins
reviewed
Jan 10, 2024
… RHT to support concurrency
hackerwins
approved these changes
Jan 19, 2024
hackerwins
pushed a commit
that referenced
this pull request
Jan 19, 2024
This commit added tests for Tree behavior in concurrency scenarios:
Styles by 2 users (4 * 6 * 6 = 144 cases):
- Ranges(4)
- A = B
- A contains B
- A and B are intersecting
- not intersecting
- Operations for both A and B(6)
- `RemoveStyle({'bold'})`
- `Style({'bold': 'aa'})`
- `Style({'bold': 'bb'})`
- `RemoveStyle({'italic'})`
- `Style({'italic': 'aa'})`
- `Style({'italic': 'bb'})`
Edit and Style (6 * 5 * 2 = 60 cases):
- Ranges(6)
- A = B
- A contains B
- B contains A
- A and B are intersecting
- B is next to A
- A is next to B.
- Operations for A(5)
- Insert front of range
- Insert back of range
- Insert middle of range
- Delete
- Change
- Operations for B(2)
- `RemoveStyle({'bold'})`
- `Style({'bold': 'aa'})`
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Tree.RemoveStyle.RHTbehavior in a concurrency scenario:RemoveStyle({'bold'}),Style({'bold': 'aa'}),Style({'bold': 'bb'}),RemoveStyle({'italic'}),Style({'italic': 'aa'}),Style({'italic': 'bb'}).RemoveStyle({'bold'}),Style({'bold': 'aa'}).Which issue(s) this PR fixes:
Addresses #626
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: