Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DARK: Remove incorrect use of <label> tag #25

Merged
merged 3 commits into from
Aug 15, 2024
Merged

DARK: Remove incorrect use of <label> tag #25

merged 3 commits into from
Aug 15, 2024

Conversation

eihabkhan1
Copy link
Collaborator

@eihabkhan1 eihabkhan1 commented Aug 15, 2024 •
edited
Loading

JIRA Ticket

DARK

<label> element used with no adjacent or child input element. Practically has no effect.

Prerequisites

  • Have at least one product with at least one variant

QA Steps

  • Go to the product page
  • Open the dev tools (⌘ + ⌥ + I)
  • Follow the steps in the image below
    Screenshot 2024-08-15 at 3 58 28 PM
  • Ensure that no Incorrect use of <label for=FORM_ELEMENT> issue is thrown

@eihabkhan1 eihabkhan1 self-assigned this Aug 15, 2024
@eihabkhan1 eihabkhan1 added in progress Currently being developed. Ready for review Requires a review from another developer. and removed in progress Currently being developed. labels Aug 15, 2024
@eihabkhan1 eihabkhan1 marked this pull request as ready for review August 15, 2024 15:04
@ibrilBadreddine ibrilBadreddine added Reviewed PR has been reviewed and approved. and removed Ready for review Requires a review from another developer. labels Aug 15, 2024
@eihabkhan1 eihabkhan1 merged commit df963f9 into master Aug 15, 2024
@eihabkhan1 eihabkhan1 deleted the best-practices branch August 15, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibrilBadreddine ibrilBadreddine ibrilBadreddine approved these changes

Assignees

@eihabkhan1 eihabkhan1

Labels
Reviewed PR has been reviewed and approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eihabkhan1 @ibrilBadreddine