Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DARK: Remove incorrect use of <label> tag #25

Merged
merged 3 commits into from
Aug 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove incorrect use of <label> tag (harmony)
eihabkhan1 committed Aug 15, 2024
commit 09df10dacd9397deac1b0ccd4b4cb803d80e4445
5 changes: 2 additions & 3 deletions themes/harmony/snippets/product-variants.liquid
Original file line number Diff line number Diff line change
@@ -5,12 +5,11 @@
data-type='{{ option.type }}'
data-name='{{ option.name | escape }}'
>
<label
<p
class='product-option-title'
for='{{ option.name }}'
>
{{- option.name -}}
</label>
</p>
{% case option.type %}
{% when 'dropdown' %}
<div class='dropdown-input'>