[WIP] Use tox for managing environments #2537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(It may also end up being the case that this gets us nothing, in which case, nothing ventured, nothing lost.) |
munkm
added
the
infrastructure
|
I note that we can avoid the extra file now that we have a pyproject.toml |
|
I kind of felt ambivalent about this, too. I am not sure it solves anything
for us but maybe I'm wrong.
…On Tue, Sep 15, 2020, 12:06 PM Clément Robert ***@***.***> wrote:
I note that we can avoid the extra file now that we have a pyproject.toml
(https://tox.readthedocs.io/en/latest/example/basic.html)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2537 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXO3CY4NNEHKC6VX5EPDSF6NINANCNFSM4MHF2VVA>
.
|
|
well if the goal is purely to simplify our usage of Travis I think the solution might just be to migrate to GH workflows for unit tests. And from what I understand tox doesn't add anything there. |
|
Sounds good to me. Feel free to close it, unless there's a good reason not
to!
…On Tue, Sep 15, 2020 at 12:12 PM Clément Robert ***@***.***> wrote:
well if the goal is purely to simplify our usage of Travis I think the
solution might just be to migrate to GH workflows for unit tests. And from
what I understand tox doesn't add anything there.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2537 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXO5SBIM4Z7TPK3DBWN3SF6N7ZANCNFSM4MHF2VVA>
.
|
|
I think it's ok to close for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2513, #2450 and a couple others, I'd like to propose that we explore simplifying our usage of travis. Instead of having a large
.travis.ymlfile, I think simplifying to usetox.iniwould be prudent.This is a rough draft of a very simple tox ini file. Using it with travis would look something like what's outlined in this blog post, and would reduce the travis config file in size -- and probably help us with migrating to something like Circle CI or Github Actions in the future.
This PR will be a staging ground for replicating the travis configuration in tox.