Enhancement: Add Education Section to Student Application Endpoint Response #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why? It helps encourage the one model one file approach.
This gives us access tonne of values techniques, like shared param extractors and dependent object lookups.
Next I need to return the study area and program details.
It seems that mostly boolean values are required.
Why? the program table appears to basically be a constant.
A person might not have a sex or language so these need to be left joins to avoid excluding valid person data.
Why? To match the table name. Yeah its redundant, but I think simplicity is best for now.
I haven't been adding all the relationships, just the ones I've used so far.
Why? To make room for actual funding requests section.
Why? So I can generate the massive ERD that this project uses.
Why? To make use of the database schema restore in db/initializers/setup.sql. I was originally hoping to move everything to the default dbo schema, but this seems like it will be too big a problem to solve for now. Instead I'm opting to use a database restore, then truncate all tables for test.
Why? Its much easier to work with an manipulate this way.
This seems like something that will need to be backed by the education table at some point?
klondikemarlen
force-pushed
the
issue-24/add-education-section-to-student-application-endpoint-response
branch
from
2f596f6
to
3249f4f
Compare
|
I created this against the wrong repo, sorry!! Closing in favour of icefoganalytics#25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to icefoganalytics/student-financial-aid#2
Fixes icefoganalytics#24
Context
As part of the "view submitted applications and their current status" project, this task covers returning the education data.
Data Format
{ "id": "some-application-id", "education": { "educationHistory": [{ "leftHighSchool": "2023/02", "school": 310 }] }, }Testing Instructions
sfa-clientback-end viaAPI_PORT=3100 db upstudent-financial-aidback-end viastudent-financial-aidfront-end viahttp://localhost:3000/api/portal/students/250/applications/4299. It will be an empty blob.