Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add Education Section to Student Application Endpoint Response #92

Closed
wants to merge 84 commits into from
Closed

Enhancement: Add Education Section to Student Application Endpoint Response #92

wants to merge 84 commits into from

Commits on Aug 11, 2023

  1. 🚧 Add application and application draft routing concepts.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    254b53f View commit details
    Browse the repository at this point in the history

  2. 🚧 Begin fleshing out application controller and services.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1906dde View commit details
    Browse the repository at this point in the history

  3. 🚧 Flesh out application controller and backing service a little more.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    92de07f View commit details
    Browse the repository at this point in the history

  4. 🚚 Require a little to make space for other components.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2b5fc17 View commit details
    Browse the repository at this point in the history

  5. ⏪ Avoid mutating application service as I'm no longer using it.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    52758a5 View commit details
    Browse the repository at this point in the history

  6. ♻️ Make class the default export. 

    Why? It helps encourage the one model one file approach.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a15ab03 View commit details
    Browse the repository at this point in the history

  7. 🚧 Add basic student application drafts wiring.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f18a75a View commit details
    Browse the repository at this point in the history

  8. ✨ Add data serialization to student applications controller.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    bc90d5d View commit details
    Browse the repository at this point in the history

  9. 🚧 Add minimal serialization to application drafts endpoint.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4341ef2 View commit details
    Browse the repository at this point in the history

  10. ♻️ Implemented controller instance per request usage. 

    This gives us access tonne of values techniques, like shared param extractors and dependent object lookups.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    31a10fe View commit details
    Browse the repository at this point in the history

  11. 🎨 Add better type checking to "routedTo" helper.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8f46ce6 View commit details
    Browse the repository at this point in the history

  12. 🪲 Return functions from controllers or external dependencies can't aw… 

    …ait them.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    da3e01d View commit details
    Browse the repository at this point in the history

  13. ✅ Ugly and hacky test example for controller.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c057e98 View commit details
    Browse the repository at this point in the history

  14. 🪲 Fix binding of this in controller routing instantiator.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4313942 View commit details
    Browse the repository at this point in the history

  15. 🎨 Standardize naming convention of application draft model file.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    181c81a View commit details
    Browse the repository at this point in the history

  16. ✨ Standardize application list view with as much info as I have.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3a2fd87 View commit details
    Browse the repository at this point in the history

  17. 🚧 Begin serializing a detailed application view.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8ec7216 View commit details
    Browse the repository at this point in the history

  18. ✨ Add institution model.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    04d4da6 View commit details
    Browse the repository at this point in the history

  19. ✨ Support returning the application institution if it exists.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    146653a View commit details
    Browse the repository at this point in the history

  20. 🚧 Return institution info in serializer. 

    Next I need to return the study area and program details.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a1610bb View commit details
    Browse the repository at this point in the history

  21. ✨ Add program modeling to application.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ca16958 View commit details
    Browse the repository at this point in the history

  22. 🎨 Match application_draft interface with null constraint in database.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    09dff96 View commit details
    Browse the repository at this point in the history

  23. 🎨 Match application interface with database null constraints. 

    It seems that mostly boolean values are required.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3ee614a View commit details
    Browse the repository at this point in the history

  24. 🚧 Add program details to program details hash.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ad0e3a0 View commit details
    Browse the repository at this point in the history

  25. ♻️ Drop program hash and just return details as name. 

    Why? the program table appears to basically be a constant.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    32e5b36 View commit details
    Browse the repository at this point in the history

  26. 🚧 Add attendance files to application serializer.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3e15e5c View commit details
    Browse the repository at this point in the history

  27. 🎨 Fix some casing in model interfaces.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ce2969d View commit details
    Browse the repository at this point in the history

  28. 🎩 Begin modeling database.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    64d494e View commit details
    Browse the repository at this point in the history

  29. 📝 Update comment about legacy application.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    311b7e8 View commit details
    Browse the repository at this point in the history

  30. ✨ Add funding request modeling.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1ac965a View commit details
    Browse the repository at this point in the history

  31. 🎩 Add request type modelling.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d2639d2 View commit details
    Browse the repository at this point in the history

  32. ✨ Add helper service to load application funding requests.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9a010a3 View commit details
    Browse the repository at this point in the history

  33. ✨ Add funding sources (funding_requests) serialization.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    655db9a View commit details
    Browse the repository at this point in the history

  34. 🚧 Building out funding sources csfaAmounts.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9d7328a View commit details
    Browse the repository at this point in the history

  35. ♻️ Use singular name for model.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    0fc9790 View commit details
    Browse the repository at this point in the history

  36. ♻️ Use shared constant for CSFA amounts. 

    These values are defined on the front-end, and it might be a good idea to serve them up via an endpoint at some point. Or replace them with an entirely different concept.

Such as performing all this logic on the front-end.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    33a5f1e View commit details
    Browse the repository at this point in the history

  37. 🔤 Alphabetize imports.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    557d60c View commit details
    Browse the repository at this point in the history

  38. 🎩 Model funding source and csfa amount constants.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a6bdaa2 View commit details
    Browse the repository at this point in the history

  39. 🔤 Alphabetize relationships.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    13e2123 View commit details
    Browse the repository at this point in the history

  40. ✨ Add student model linked to application.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    15d45e9 View commit details
    Browse the repository at this point in the history

  41. 🎨 Prettify erd code.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    c23b5bb View commit details
    Browse the repository at this point in the history

  42. 🎩 Add student modeling info.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1cbe4db View commit details
    Browse the repository at this point in the history

  43. 🚧 Add placeholder wiring for personal details in application serializer.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a3a3e46 View commit details
    Browse the repository at this point in the history

  44. 🔥 Drop now redundant manual reference to schema. 

    Schema is now set via config; although, it can be overridden at will.

I might end up breaking this out an applying it per-commit?
Otherwise the commits that introduced this will be broken.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    699b524 View commit details
    Browse the repository at this point in the history

  45. ✨ Add person model linked to student.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e694b18 View commit details
    Browse the repository at this point in the history

  46. 🎩 Diagram person model.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e8ad758 View commit details
    Browse the repository at this point in the history

  47. ✨ Load student and person data; serialize to personal details.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8397d72 View commit details
    Browse the repository at this point in the history

  48. 🚧 Add mock of addresses section.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1ff078c View commit details
    Browse the repository at this point in the history

  49. ✨ Add person address model.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    500348f View commit details
    Browse the repository at this point in the history

  50. 🎩 Add person address modeling to erd.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2ca7980 View commit details
    Browse the repository at this point in the history

  51. ✨ Add address serialization to application serializer.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    782f645 View commit details
    Browse the repository at this point in the history

  52. 🎩 Add erd info about address types.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    68b1ede View commit details
    Browse the repository at this point in the history

  53. ♻️ Simply person details generation. 

    How? Use a Person object instead of a Student.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e6b9c55 View commit details
    Browse the repository at this point in the history

  54. 🚧 begin building out statistical section of application serializer.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    83b7034 View commit details
    Browse the repository at this point in the history

  55. 🪲 Fix bug in student retrieval. 

    I wasn't returning ids for sub-objects as part of the parent object.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5a2c217 View commit details
    Browse the repository at this point in the history

  56. 🚧 Add citizenship to application data.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d65c74c View commit details
    Browse the repository at this point in the history

  57. 🔥 Drop now unused language import.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a34641a View commit details
    Browse the repository at this point in the history

  58. 📝 Add note about serializer future patterns.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f3c59ef View commit details
    Browse the repository at this point in the history

  59. 👌 Add missing program details section field.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    6a7264b View commit details
    Browse the repository at this point in the history

  60. 📝 Add note about possibility of needing a "parents" field.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    471ee49 View commit details
    Browse the repository at this point in the history

  61. ✨ Add statistical section to application serializer.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    444b86c View commit details
    Browse the repository at this point in the history

  62. ✨ Add student consent model.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    63ec4dd View commit details
    Browse the repository at this point in the history

  63. 🎩 Add disability, language, sex and student consent modeling.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b0069cc View commit details
    Browse the repository at this point in the history

  64. 🪲 Fix join condition between person and sex and language. 

    A person might not have a sex or language so these need to be left joins to avoid excluding valid person data.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ab85ffa View commit details
    Browse the repository at this point in the history

  65. ♻️ Rename addresses assocation on person to personAddresses. 

    Why? To match the table name. Yeah its redundant, but I think simplicity is best for now.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    30583da View commit details
    Browse the repository at this point in the history

  66. ✨ Add student consents section.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    29b45d8 View commit details
    Browse the repository at this point in the history

  67. ✨ Return residency info in student application endpoint.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    43564b7 View commit details
    Browse the repository at this point in the history

  68. 🎩 Add residency to ERD. 

    I haven't been adding all the relationships, just the ones I've used so far.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    7642975 View commit details
    Browse the repository at this point in the history

  69. 🚧 Begin work on returning education info.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9333799 View commit details
    Browse the repository at this point in the history

  70. 🚚 Rename funding request to funding sources. 

    Why? To make room for actual funding requests section.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d259888 View commit details
    Browse the repository at this point in the history

  71. ♻️ Switch to return full funding request and request type objects.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    31299f0 View commit details
    Browse the repository at this point in the history

  72. ✨ Return assessments from funding request service.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2b6c817 View commit details
    Browse the repository at this point in the history

  73. ✨ Add disbursements to assessments payload.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    11e3182 View commit details
    Browse the repository at this point in the history

  74. 🔨 Add plantuml server to development environment. 

    Why? So I can generate the massive ERD that this project uses.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    aa17ef6 View commit details
    Browse the repository at this point in the history

  75. 🎩 Add assessement to funding request modeling.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    fd7f023 View commit details
    Browse the repository at this point in the history

  76. 🎩 Add data modeling for disbursement model.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    424ffda View commit details
    Browse the repository at this point in the history

  77. 🔧 Change default schema for test setup. 

    Why? To make use of the database schema restore in db/initializers/setup.sql.
I was originally hoping to move everything to the default dbo schema, but this seems like it will be too big a problem to solve for now.

Instead I'm opting to use a database restore, then truncate all tables for test.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    57023d8 View commit details
    Browse the repository at this point in the history

  78. 🪲 Fix typo in route naming.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3292155 View commit details
    Browse the repository at this point in the history

  79. 🏰 Handle case where application is not found.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    28eb33a View commit details
    Browse the repository at this point in the history

  80. 🎨 Prettify portal index.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ad22ab2 View commit details
    Browse the repository at this point in the history

  81. 🎨 Clean up student application draft database access and prettify.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    165e1db View commit details
    Browse the repository at this point in the history

  82. 🪲 Fix student application draft service return type.

    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2bdbe41 View commit details
    Browse the repository at this point in the history

  83. ✨ Return application draft application json as object instead of string. 

    Why? Its much easier to work with an manipulate this way.
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    388bda0 View commit details
    Browse the repository at this point in the history

  84. ✨ Add education history to student application blob. 

    This seems like something that will need to be backed by the education table at some point?
    @klondikemarlen
    klondikemarlen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    3249f4f View commit details
    Browse the repository at this point in the history