-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration via environment variables doesn't work except GOTTY_CONFIG #122
Labels
Comments
gurjeet
added a commit
to gurjeet/gotty-cf-bash
that referenced
this issue
Nov 1, 2016
Added a manifest file that is used by default by Cloud Foundry's cli `cf push` command. This manifest causes GoTTY to launch bash and allow it to accept keystrokes. We do not use GoTTY's -c parameter to force use of credentials, because that requires that the user update the manifest file before `cf push`, and also have the utilities to generate secure password on her machine. We use the alternative method to obscure the access to this app by recommending (in README) to use the --random-route option. Updated code to listen on environment variable PORT. This overrides logic that purportedly supports choosing a different port via environment variable GOTTY_PORT. But since that doesn't really work (see issue yudai#122) it's okay for us to hack this to support Cloud Foundry.
yudai
added a commit
that referenced
this issue
Aug 8, 2017
To fix #122. IsSet() doesn't return true even when env variables are set.
Merged
yudai
added a commit
that referenced
this issue
Aug 8, 2017
To fix #122. IsSet() doesn't return true even when env variables are set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gotty version 0.0.13
Set some environment variables:
Run and see that configuration is not applied:
But GOTTY_CONFIG is working:
The text was updated successfully, but these errors were encountered: