Support deploying bash in Cloud Foundry via GoTTY #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a manifest file that is used by default by Cloud Foundry's cli `cf push` command. This manifest causes GoTTY to launch bash and allow it to accept keystrokes. We do not use GoTTY's -c parameter to force use of credentials, because that requires that the user update the manifest file before `cf push`, and also have the utilities to generate secure password on her machine. We use the alternative method to obscure the access to this app by recommending (in README) to use the --random-route option. Updated code to listen on environment variable PORT. This overrides logic that purportedly supports choosing a different port via environment variable GOTTY_PORT. But since that doesn't really work (see issue yudai#122) it's okay for us to hack this to support Cloud Foundry.
|
Hi, thank your for the PR. I currently don't want to add files for a specific environment like CF manifests, BOSH releases, docker-compose files, Kubernetes pod files, because there are too many candidates and hard to maintain. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a manifest file that is used by default by Cloud Foundry's cli
cf pushcommand. This manifest causes GoTTY to launch bash and allowit to accept keystrokes. We do not use GoTTY's -c parameter to force use
of credentials, because that requires that the user update the manifest
file before
cf push, and also have the utilities to generate securepassword on her machine. We use the alternative method to obscure the
access to this app by recommending (in README) to use the --random-route
option.
Updated code to listen on environment variable PORT. This overrides
logic that purportedly supports choosing a different port via environment
variable GOTTY_PORT. But since that doesn't really work (see issue #122)
it's okay for us to hack this to support Cloud Foundry.