Charts - Fix for when Bar/Column series throw errors when used independently. #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted common functions from date-format, Added tests. Still need to add more parsers.
Have to do more testing.
of instance properties to pass data around.
Changed parseDigits to use regexp. Now using NaN as an error flag that propagates easily.
string, because I was doing it a lot anyway and it saved nothing. Added tests for each of the formatting specs and fixed some of them
Fixed an error in parse.
which will be assumed to be the formatting specification. The API doc comments were fixed - xPad was documented though it can't actually be accessed - static methods were not declared so - a few others. JSHint errors were also fixed: - multiple vars - mixed tabs and spaces - trailing whitespace - double equals turned into triple equals
- mixed tabs and spaces - multiple var declarations - double equals into triple equals - trailing spaces API docs fixed: - static methods were declared so
- added static declaration on most methods - added protected to some Fixed error in I and l formats (12:00am is actually 00:00). Added support for %Z and derived (%c). Added timezone abbreviations table. Postponed century calculation. Uses Date.UTC when timezone info is present.
(timezone abbreviations)
parse or format so that you can switch languages on the fly.
Discovered errors in military timezones.
format uses. Added tests, updated the API docs and user guide.
Said function gets cached. Dropped uses of Y.Lang.
I have to pay attention to JSHint messages. .... and so on.
While trying to write a better version I found some of the tests didn't cover some edge conditions and they didn't check the groups of numbers were not reversed or shuffled around.
processing faster. Changed the first element from a string with the name of the function to an actual function reference. Added the configurable `cutoff` property to be used as the default. Added API docs and general comments. Added a few more tests.
it is now done in just one place.
Conflicts: build/yui-nodejs/yui-nodejs-min.js build/yui/yui-min.js
YUI and Loader build for latest Gallery build
Conflicts: build/dom-base/dom-base-coverage.js build/dom-base/dom-base-min.js
Promises cleanup
…es had errors. Fix yui#1390.
|
whoopsie-daisy, wrong branch. derp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issue in which independently used Bar/Column series instances had errors.
Proposed fix for: #1390
Need to test: