Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts - Fix for when Bar/Column series throw errors when used independently. #1394

Closed
wants to merge 155 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
155 commits
Select commit Hold shift + click to select a range
08cb061
Added parsing with format.
Satyam Mar 26, 2013
ba86ae6
All parsers in.
Satyam Mar 27, 2013
2d47f3a
Avoiding packing and unpacking arguments by using a couple
Satyam Mar 27, 2013
e9a4673
Completed the API docs.
Satyam Mar 28, 2013
b2c8ef8
Instead of buffer and index, I switched to shifting the
Satyam Mar 28, 2013
73e3985
Merge branch 'dev-3.x' into dateparser
Satyam Mar 29, 2013
8c6840b
User Guide.
Satyam Mar 29, 2013
003bf6e
Merge branch 'dev-3.x' into dateparser
Satyam Apr 2, 2013
0138600
Y.Date.format accepts the second argument to be a string
Satyam Apr 4, 2013
41c186e
JSHint errors fixed:
Satyam Apr 4, 2013
11e044e
Fixed API docs comments
Satyam Apr 4, 2013
951a27a
Improved and added to tests
Satyam Apr 4, 2013
ee821f6
Updated user guide indicating limited support for %Z
Satyam Apr 4, 2013
b3b845b
Loads locale language resources on each call to
Satyam Apr 4, 2013
2f018b2
Changed a few tests so they work across different time-zones.
Satyam Apr 4, 2013
79937e1
Added further tests to almost full coverage.
Satyam Apr 4, 2013
5b38d7d
Hopefully this will make the test timezone independent.
Satyam Apr 4, 2013
40f897e
Added to parse the same optional config argument that
Satyam Apr 5, 2013
f52d102
Moved the regular expression out of the method.
Satyam Apr 5, 2013
a76da4e
Merge branch 'dev-3.x' into numberparser
Satyam Apr 19, 2013
8fd4ddc
Added a parse function builder.
Satyam Apr 19, 2013
fa08886
I have to pay attention to JSHint messages.
Satyam Apr 19, 2013
138ce7d
Added some more tests for edge conditions.
Satyam Apr 20, 2013
4221ed0
Merge branch 'dev-3.x' into numberparser
Satyam Apr 20, 2013
5ba0404
Merge branch 'dev-3.x' into dateparser
Satyam Apr 20, 2013
8260b46
Redesigned the parser to use Y.cached.
Satyam Apr 21, 2013
09eb255
Standardized the format of the parsers hash to make
Satyam Apr 21, 2013
c89af94
Leading whitespace was being trimmed in too many places,
Satyam Apr 21, 2013
08d400a
Merge branch 'dev-3.x' into dateparser
Satyam May 2, 2013
cc37782
Merge branch 'dev-3.x' into numberparser
Satyam May 2, 2013
69b90f5
Merge branch 'dev-3.x' into numberparser
Satyam May 22, 2013
9d3cac2
Added Histoy.md entry
Satyam May 22, 2013
42beec3
Merged new tests into existing suite.
Satyam May 22, 2013
5b527eb
Added tests for inputs that return null.
Satyam May 22, 2013
674d175
Merge branch 'dev-3.x' into dateparser
Satyam May 22, 2013
174c9e4
Added entry to history.md file
Satyam May 22, 2013
c24d2c6
Added a few more tests
Satyam May 23, 2013
9e431fa
A blank, non-empty string now returns null.
Satyam May 24, 2013
1e8a5b0
Added DataTable Keyboard Navigation module and tests.
Satyam Apr 9, 2013
453bf6f
Changed dependencies based on YUI Module Explorer.
Satyam Apr 11, 2013
590d641
Added tests for nested table headers
Satyam Apr 11, 2013
65dbc1f
Added missing dependency.
Satyam Apr 11, 2013
44687d2
Build regular expression to extract column key via getClassName.
Satyam Apr 11, 2013
1af9d0a
Added test for PageUp on nested headers.
Satyam Apr 11, 2013
57b7ec7
Changed keyActions from attribute to property.
Satyam Apr 12, 2013
d67a796
Added user guide documentation for datatable-keynav.
Satyam Apr 12, 2013
518c0c7
Added tests to navigate into headers or not.
Satyam Apr 12, 2013
b3658ce
Dropped the 'groups' YUI configuration entry.
Satyam Apr 12, 2013
e1e6b3c
Corrected the API docs and user guide to state that use of
Satyam Apr 13, 2013
62b5d92
Added history.md entry
Satyam May 24, 2013
2805a5d
key actions can now be specified with keycodes or alias
Satyam May 24, 2013
45eac2b
Fixed a few jshint errors in the tests
Satyam May 24, 2013
cfbd2a0
Changed tests to work in IE
Satyam Jul 11, 2013
9ef88dd
Update history entry.
apipkin Aug 6, 2013
d239587
Merge branch 'dev-3.x' of https://github.com/yui/yui3 into dt-nav
apipkin Sep 5, 2013
ff2b605
Merge branch 'dev-3.x' of https://github.com/yui/yui3 into dt-nav
apipkin Sep 11, 2013
e8c1dd3
Fix a few navigation issues in the header.
apipkin Sep 18, 2013
b273b81
Unit tests for adjustments and higher coverage score.
apipkin Sep 18, 2013
33ce517
Fix minor issues breaking in IE
apipkin Sep 18, 2013
4b54659
Clean up column name retrieval from cell.
apipkin Sep 19, 2013
8f47586
Address error in destroy method for pie chart.
tripp Sep 19, 2013
5076c5e
Update charts unit tests.
tripp Sep 23, 2013
93170b3
Update dependencies for navigation
apipkin Sep 26, 2013
cbba923
Update history
apipkin Sep 26, 2013
cf663b7
Merge branch 'dateparser' of https://github.com/Satyam/yui3-1 into da…
apipkin Sep 26, 2013
02edfa6
Update test for coverage and accuracy.
apipkin Sep 27, 2013
0dff07d
Update History.
apipkin Sep 27, 2013
c276dee
Merge branch 'numberparser' of https://github.com/Satyam/yui3-1 into …
apipkin Sep 27, 2013
4819b79
Update History.
apipkin Sep 27, 2013
59d615d
Add waitFor() method to TestCase
lsmith Oct 3, 2013
7b88bca
Add test coverage for new waitFor() method
lsmith Oct 3, 2013
b4829d9
Typo fix.
lsmith Oct 3, 2013
d399819
Fix preexisting APIDoc typo. 0 => 10000ms
lsmith Oct 3, 2013
cf5d5ee
Merge branch 'release-3.13.0' into dev-3.x
apipkin Oct 4, 2013
a1b4e03
Merge branch 'waitfor' into dev-3.x
lsmith Oct 7, 2013
2bcc93c
Build YUITest
lsmith Oct 7, 2013
938651d
Add dom-base build files.
tripp Oct 7, 2013
1bd3790
Merge branch 'release-3.13.0' into dev-3.x
tripp Oct 7, 2013
254f17e
Merge branch 'dev-master' into dev-3.x
Oct 7, 2013
5dfe2c0
Revert @reid's revert of the bad commit
Oct 7, 2013
f70e387
Merge branch 'dev-master' into dev-3.x
triptych Oct 7, 2013
baf2cb6
Merge remote-tracking branch 'upstream/dev-3.x' into dev-3.x
tripp Oct 7, 2013
2eb88ff
Update package.json with pre
tripp Oct 7, 2013
bb5c1df
Merge branch 'dev-3.x' of https://github.com/yui/yui3 into dateparser
apipkin Oct 8, 2013
e874023
Build.
apipkin Oct 8, 2013
9742da8
Merge branch 'dev-3.x' of https://github.com/yui/yui3 into numberparser
apipkin Oct 8, 2013
f14a6f5
Build.
apipkin Oct 8, 2013
88fd17c
Address issue in which multipe node reference were created for a tool…
tripp Oct 9, 2013
83febe4
Merge branch 'dev-master' into dev-3.x
Oct 9, 2013
c52490a
Merge branch 'dev-master' into dev-3.x
Oct 10, 2013
421496f
Merge branch 'dev-master' into dev-3.x
Oct 10, 2013
f5b913d
Merge branch 'dev-master' into dev-3.x
Oct 10, 2013
ed0db9b
Valid `value` to ensure it is strictly numeric.
Oct 10, 2013
c779b65
Addition of unit tests to ensure `Slider` only accepts numeric values.
Oct 10, 2013
5d53d06
Correction of `on` to `after`.
Oct 10, 2013
7728fe0
Addressed issue with leftover text nodes in chart's legend. Addressed…
tripp Oct 10, 2013
bca4241
Removal of `validator` logic in setter.
Oct 10, 2013
850c31e
Addition of validation logic in `_setNewValue`.
Oct 10, 2013
ff374b5
Clean up chart's series-tests unit test for ie.
tripp Oct 10, 2013
34fab5f
Remove unused variable from CartesianChartLegend.
tripp Oct 10, 2013
41153f6
Add destructor method to PieChart. Fix #1139.
tripp Oct 10, 2013
691f2e3
Changes from yui build. (no min changes)
tripp Oct 10, 2013
4117c44
Added Y.ArrayAssert.isUnique()
customcommander Oct 11, 2013
e019d12
Build
customcommander Oct 11, 2013
6c127b1
Merge branch 'dev-3.x' of https://github.com/yui/yui3 into dt-nav
apipkin Oct 11, 2013
b9e8e40
Update History.
apipkin Oct 11, 2013
80006f1
Build dt-nav
apipkin Oct 11, 2013
bd4ced7
Fix an undeclared variable
okuryu Oct 13, 2013
704c2f5
Merge branch 'dev-master' into dev-3.x
ekashida Oct 14, 2013
9f60451
Merge branch 'issue1139' into dev-3.x
tripp Oct 14, 2013
d83b9d8
Charts build files.
tripp Oct 14, 2013
88767fa
Update isPromise for compatibility with A+ 1.1
juandopazo Oct 14, 2013
f2b2c24
Don't re-create callback lists. Resolves #571
juandopazo Oct 14, 2013
ca4ede8
Small cleanup and perf improvement
juandopazo Oct 14, 2013
9adfc6b
Deprecate getStatus
juandopazo Oct 14, 2013
b6cdfdc
Add a debug message for unhandled rejections
juandopazo Oct 14, 2013
005d1aa
Missing semicolon
juandopazo Oct 14, 2013
4e820e8
Merge branch 'slider-validation-fix' of github.com:ezequiel/yui3 into…
tripp Oct 15, 2013
430cf88
Add slider build files.
tripp Oct 15, 2013
27cda33
Add src parameter to log calls
juandopazo Oct 15, 2013
1eeeba3
Do not return inside try...catch
juandopazo Oct 15, 2013
c944a83
Add HISTORY entry
juandopazo Oct 15, 2013
039e720
Use NAME in log's third argument
juandopazo Oct 16, 2013
cfdb0db
Update the history of Calendar
okuryu Oct 16, 2013
20175da
Merge branch 'dev-master' into dev-3.x
ekashida Oct 17, 2013
e9201e6
Merge branch 'dev-master' into dev-3.x
ericf Oct 17, 2013
986bbfe
Merge branch 'fix1307' into dev-3.x
okuryu Oct 21, 2013
7ab7f25
Build Calendar
okuryu Oct 21, 2013
c340a64
Merge branch 'dev-master' into dev-3.x
tripp Oct 23, 2013
81309e7
Merge branch 'dev-master' into dev-3.x
tripp Oct 23, 2013
df85a97
Merge remote-tracking branch 'upstream/dev-master' into dev-3.x
Oct 24, 2013
d5c7cca
Resolve build conflicts with `yui-nodejs-min.js` and `yui-min.js`.
Oct 24, 2013
7e51a33
Merge branch 'dev-master' into dev-3.x
ekashida Oct 24, 2013
d300788
Merge remote-tracking branch 'upstream/dev-master' into dev-3.x
Oct 24, 2013
3896e98
Resolve build conflicts with `dom-base-coverage.js` and `dom-base-min…
Oct 24, 2013
f6875a3
Merge remote-tracking branch 'upstream/dev-master' into dev-3.x
Oct 25, 2013
df03667
Merge remote-tracking branch 'customcommander/ArrayAssert.isUnique' i…
Oct 25, 2013
ced5e54
Build Test.
Oct 25, 2013
31570ea
Merge branch 'dev-master' into dev-3.x
ekashida Oct 28, 2013
c17ffd9
Merge pull request #1320 from juandopazo/promises-cleanup
juandopazo Oct 29, 2013
7cb72ad
Merge branch 'dev-master' into dev-3.x
Oct 29, 2013
dc4e940
Merge remote-tracking branch 'upstream/dev-master' into dev-3.x
Oct 29, 2013
8e60e65
Build Promise.
Oct 29, 2013
d79511e
Merge branch 'dev-master' into dev-3.x
Oct 30, 2013
e4713a8
Merge remote-tracking branch 'upstream/dev-master' into dev-3.x
Nov 3, 2013
4585c2f
Merge branch 'dev-master' into dev-3.x
Nov 9, 2013
3d48386
Merge branch 'dev-master' into dev-3.x
Nov 10, 2013
fe35132
Merge branch 'dev-master' into dev-3.x
Nov 10, 2013
30c6313
Merge branch 'dev-master' into dev-3.x
Nov 10, 2013
3b5a962
Merge branch 'dev-master' into dev-3.x
Nov 10, 2013
a088ae9
Merge branch 'dev-master' into dev-3.x
juandopazo Nov 11, 2013
37e8e60
Merge branch 'dev-master' into dev-3.x
juandopazo Nov 11, 2013
d853c83
Merge branch 'dev-master' into dev-3.x
tripp Nov 12, 2013
d6e6f6c
Merge branch 'dev-master' into dev-3.x
tripp Nov 13, 2013
4c1ef7b
Addressed issue in which independently used Bar/Column series instanc…
tripp Nov 13, 2013
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/calendar/calendar-coverage.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions build/calendar/calendar-debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ Y.Calendar = Y.extend(Calendar, Y.CalendarBase, {
maxDate = this.get('maximumDate'),
dates = [],
i, l,
paneDate,
paneNum;

if (!minDate && !maxDate) {
Expand Down
4 changes: 2 additions & 2 deletions build/calendar/calendar-min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions build/calendar/calendar.js
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,7 @@ Y.Calendar = Y.extend(Calendar, Y.CalendarBase, {
maxDate = this.get('maximumDate'),
dates = [],
i, l,
paneDate,
paneNum;

if (!minDate && !maxDate) {
Expand Down
4 changes: 2 additions & 2 deletions build/charts-base/charts-base-coverage.js

Large diffs are not rendered by default.

78 changes: 65 additions & 13 deletions build/charts-base/charts-base-debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -1171,8 +1171,7 @@ ChartBase.ATTRS = {
{
if(this._description)
{
this._description.setContent("");
this._description.appendChild(DOCUMENT.createTextNode(val));
this._description.set("text", val);
}
return val;
}
Expand Down Expand Up @@ -1622,7 +1621,7 @@ ChartBase.prototype = {
cb.setAttribute("aria-describedby", id);
description.set("id", id);
description.set("tabIndex", -1);
description.appendChild(DOCUMENT.createTextNode(this.get("ariaDescription")));
description.set("text", this.get("ariaDescription"));
liveRegion.set("id", "live-region");
liveRegion.set("aria-live", "polite");
liveRegion.set("aria-atomic", "true");
Expand Down Expand Up @@ -1690,8 +1689,7 @@ ChartBase.prototype = {
{
e.halt();
msg = this._getAriaMessage(numKey);
this._liveRegion.setContent("");
this._liveRegion.appendChild(DOCUMENT.createTextNode(msg));
this._liveRegion.set("text", msg);
}
}, this), this.get("contentBox"));
if(interactionType === "marker")
Expand Down Expand Up @@ -2090,7 +2088,15 @@ ChartBase.prototype = {
if(Y_Lang.isObject(val))
{
styles = val.styles;
node = Y.one(val.node) || tt.node;
if(val.node && tt.node)
{
tt.node.destroy(true);
node = Y.one(val.node);
}
else
{
node = tt.node;
}
if(styles)
{
for(i in styles)
Expand Down Expand Up @@ -2318,7 +2324,7 @@ ChartBase.prototype = {
*/
_setText: function(textField, val)
{
textField.setContent("");
textField.empty();
if(Y_Lang.isNumber(val))
{
val = val + "";
Expand Down Expand Up @@ -2410,7 +2416,6 @@ Y.CartesianChart = Y.Base.create("cartesianChart", Y.Widget, [Y.ChartBase, Y.Ren
var bb = this.get("boundingBox"),
cb = this.get("contentBox"),
tt = this.get("tooltip"),
overlay,
overlayClass = _getClassName("overlay");
//move the position = absolute logic to a class file
bb.setStyle("position", "absolute");
Expand All @@ -2424,15 +2429,14 @@ Y.CartesianChart = Y.Base.create("cartesianChart", Y.Widget, [Y.ChartBase, Y.Ren
}
if(this.get("interactionType") === "planar")
{
overlay = DOCUMENT.createElement("div");
this.get("contentBox").appendChild(overlay);
this._overlay = Y.one(overlay);
this._overlay = Y.Node.create("<div></div>");
this._overlay.set("id", this.get("id") + "_overlay");
this._overlay.setStyle("position", "absolute");
this._overlay.setStyle("background", "#fff");
this._overlay.setStyle("opacity", 0);
this._overlay.addClass(overlayClass);
this._overlay.setStyle("zIndex", 4);
cb.append(this._overlay);
}
this._setAriaElements(bb, cb);
this._redraw();
Expand Down Expand Up @@ -5005,6 +5009,55 @@ Y.PieChart = Y.Base.create("pieChart", Y.Widget, [Y.ChartBase], {
}
msg += (itemIndex + 1) + " of " + len + ". ";
return msg;
},

/**
* Destructor implementation for the PieChart class.
*
* @method destructor
* @protected
*/
destructor: function()
{
var series,
axis,
tooltip = this.get("tooltip"),
tooltipNode = tooltip.node,
graph = this.get("graph"),
axesCollection = this._axesCollection,
seriesCollection = this.get("seriesCollection");
while(seriesCollection.length > 0)
{
series = seriesCollection.shift();
series.destroy(true);
}
while(axesCollection.length > 0)
{
axis = axesCollection.shift();
if(axis instanceof Y.Axis)
{
axis.destroy(true);
}
}
if(this._description)
{
this._description.empty();
this._description.remove(true);
}
if(this._liveRegion)
{
this._liveRegion.empty();
this._liveRegion.remove(true);
}
if(graph)
{
graph.destroy(true);
}
if(tooltipNode)
{
tooltipNode.empty();
tooltipNode.remove(true);
}
}
}, {
ATTRS: {
Expand All @@ -5021,8 +5074,7 @@ Y.PieChart = Y.Base.create("pieChart", Y.Widget, [Y.ChartBase], {
{
if(this._description)
{
this._description.setContent("");
this._description.appendChild(DOCUMENT.createTextNode(val));
this._description.set("text", val);
}
return val;
}
Expand Down
Loading