Applying pep-8 styling guide rules to src/loader/meta_join.py #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull can't be merged automatically due to changes in this file since it was submitted (before a few weeks ago we didn't accept pull requests from GitHub so this was not tracked). Closing until it can be merged properly. |
ericf
referenced
this pull request
in ericf/yui3
Jan 25, 2012
* typo in getRow
* move caption and summary attr => _uiSet* to _UI_ATTRS
* rename {classes} placeholder {className}
* header cells get column class as well
* header cells get yui3-datatable-header class
* data cells get yui3-datatable-cell class
* Core now assigns columns a _id which is name, key, or yuid w/ uniqueness counter
* column class names now yui3-datatable-col-foo (added -col-)
* use toJSON() to get data for the formatters
* replace CSS targeting tags with classes
kloots
pushed a commit
to kloots/yui3
that referenced
this pull request
Mar 28, 2012
Convert panel sprites to PNG
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small patch that only apply pep-8 styling guide rules to the src/loader/meta_join.py.
I'm applying this patch on my forked version to remove error/warning messages when I run pep8.py in my continuous integration environment.
This patch remove some trailing whitespaces too.