Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency versions. #206

Merged
merged 4 commits into from
Feb 19, 2014
Merged

Conversation

evocateur
Copy link
Contributor

Many of yuidoc's dependencies are getting quite long in the tooth. No tests fail after these updates, but I'm running some locally linked tests using other tools that consume yuidocjs to verify.

@evocateur evocateur mentioned this pull request Jan 30, 2014
@caridy
Copy link
Member

caridy commented Jan 31, 2014

Can you be more explicit about the failures? the changes seem to be completely arbitrary.

@lexander
Copy link
Contributor

Can we take these changes and look at adapting them to use enumerated ranges or 1.2.x format values?

@evocateur
Copy link
Contributor Author

@caridy These are just backward-compatible dependency updates. Using up-to-date dependencies gives npm and opportunity to dedupe things when other sibling dependencies might depend on the same modules (graceful-fs and rimraf are extremely common, for example).

@lexander Other than the aforementioned rimraf and graceful-fs (which use 2.x), all the other dependencies (save YUI) are listed in the 1.2.x style (equivalent to~1.2). I'm not sure we should loosen the yui dependency, but I'm open to 3.14.x.

Keeping graceful-fs and rimraf pinned to major version only allows important updates to modules that I've found to be very dependable adherents to semver. graceful-fs 2.0 was a very dramatic future-compatible rewrite, as well as potentially fixing many of the "I don't know why graceful-fs is barfing here" comments I've seen throughout the source.

@caridy
Copy link
Member

caridy commented Feb 1, 2014

Ok Ok, we should NOT care about new versions for the sake of dedupping, specially because yuidocs IS a devtime tool. In other words, if there is a bug, or if there is a new feature, or some big improvements in terms of time to generate docs, etc, I will be reluctant to upgrade.

Aside from that, there are changes in this diff that will just don't have any effect, e.g.: "minimatch": "~0.2.11", ---> "minimatch": "0.2.x",.

Again, I just don't want to merge arbitrary changes with unknown consequences. I'm not saying that we will not merge this, I'm saying that we should clean this PR to only upgrade those pkgs that we really need to upgrade, listing the reasons why.

"minimatch": "~0.2.11",
"graceful-fs": ">=1.1.1",
"express": "~3.1.2"
"yui": "3.14.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do think we should bump the yui dependency, possibly even to a looser 3.x spec.

@caridy
Copy link
Member

caridy commented Feb 2, 2014

+1

@caridy caridy merged commit 01a902a into yui:master Feb 19, 2014
@caridy
Copy link
Member

caridy commented Feb 19, 2014

  • yuidocjs@0.3.48

@evocateur evocateur deleted the dependency-updates branch February 19, 2014 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants