-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency versions. #206
Conversation
Can you be more explicit about the failures? the changes seem to be completely arbitrary. |
Can we take these changes and look at adapting them to use enumerated ranges or 1.2.x format values? |
@caridy These are just backward-compatible dependency updates. Using up-to-date dependencies gives npm and opportunity to dedupe things when other sibling dependencies might depend on the same modules ( @lexander Other than the aforementioned Keeping |
Ok Ok, we should NOT care about new versions for the sake of dedupping, specially because yuidocs IS a devtime tool. In other words, if there is a bug, or if there is a new feature, or some big improvements in terms of time to generate docs, etc, I will be reluctant to upgrade. Aside from that, there are changes in this diff that will just don't have any effect, e.g.: Again, I just don't want to merge arbitrary changes with unknown consequences. I'm not saying that we will not merge this, I'm saying that we should clean this PR to only upgrade those pkgs that we really need to upgrade, listing the reasons why. |
"minimatch": "~0.2.11", | ||
"graceful-fs": ">=1.1.1", | ||
"express": "~3.1.2" | ||
"yui": "3.14.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really do think we should bump the yui dependency, possibly even to a looser 3.x
spec.
+1 |
|
Many of
yuidoc
's dependencies are getting quite long in the tooth. No tests fail after these updates, but I'm running some locally linked tests using other tools that consume yuidocjs to verify.