Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency versions. #206

Merged
merged 4 commits into from
Feb 19, 2014
Merged

Update dependency versions. #206

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdb71a1
Update dependency versions.
Jan 29, 2014
4ae5f3b
No change necessary to minimatch version pattern.
Feb 2, 2014
188ec1f
Hold back on marked upgrade due to stability concerns.
Feb 2, 2014
01a902a
Revert express bump until more & better testing can be done.
Feb 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,18 @@
"main": "./lib/index",
"bin" : { "yuidoc" : "./lib/cli.js" },
"dependencies": {
"yui": "3.9.1",
"rimraf": "~2.0.0",
"yui": "3.14.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do think we should bump the yui dependency, possibly even to a looser 3.x spec.

"rimraf": "2.x",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isaacs/rimraf@v2.0.3...master

There are a number of Windows-related bugfixes, as well as error-handling changes to optimize some syscalls. From personal experience, I have great faith in the maintainer's responsibility for preserving backward compatibility, and see no harm in loosening this pin.

"marked": "~0.2.8",
"minimatch": "~0.2.11",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest minimatch is indeed handled by the current spec. I can revert this.

"graceful-fs": ">=1.1.1",
"graceful-fs": "2.x",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny enough, this particular spec already provides the latest graceful-fs, which strikes me as kind of a bad thing, historically, since we had no control over which major version we were targeting. Changing it to 2.x makes it explicitly locked, preventing potential backward-incompatible changes from breaking us.

"express": "~3.1.2"
},
"devDependencies": {
"ytestrunner": "~0.3.3",
"yuitest": ">=0.7.3",
"selleck": "~0.1",
"istanbul": "~0.1.27"
"istanbul": "0.2.x"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotwarlost/istanbul@v0.1.46...master

The biggest feature here I would like is a comment syntax for explicitly ignoring things for code coverage. The potential for adding a .istanbul.yml config file is a nice-to-have, as well.

There are no explicit bug fixes that I'm aware of, but the minor version bump seems like just paranoia on the author's part:

Up minor version due to the new way in which the global object is accessed. This should be backwards-compatible but has not been tested in the wild.

The success of the tests seems to indicate that the concern was unfounded.

},
"scripts": {
"test": "istanbul cover --print=both --yui ytestrunner -- --include ./tests/options.js --include ./tests/builder.js --include ./tests/parser.js --include ./tests/parser_coffee.js --include ./tests/files.js"
Expand Down