Skip to content

Commit

Permalink
Resulve issue project-flogo#224 GetRef() in support package should re…
Browse files Browse the repository at this point in the history
…move 'vendor' path

allows trigger developer to pass request parameters to handler w/o going through output mapper

Resulve issue project-flogo#224 GetRef() in support package should remove 'vendor' path

resubmit pull request to resolve issue project-flogo#224

Fix project-flogo#244 Trigger handler should provide option to pass request data to flow without explicit output mapping

update per comments on issue project-flogo#246
  • Loading branch information
yxuco committed Jan 4, 2021
1 parent 82972d8 commit 4f85a3b
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
19 changes: 19 additions & 0 deletions trigger/context.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,22 @@ func HandlerFromContext(ctx context.Context) (*HandlerInfo, bool) {
u, ok := ctx.Value(handlerKey).(*HandlerInfo)
return u, ok
}

// This allows trigger developer to pass request parameters to handler w/o going through output mapper, e.g.,
// ctx := trigger.NewContextWithValues(context.Background(), values)
// results, err := handler.Handle(ctx, triggerData.ToMap())

type valueKey string

const contextValueKey valueKey = "values"

// NewContextWithValues returns a new Context that carries specified request parameter values
func NewContextWithValues(ctx context.Context, values map[string]interface{}) context.Context {
return context.WithValue(ctx, contextValueKey, values)
}

// ValuesFromContext extracts request parameters from a context
func ValuesFromContext(ctx context.Context) (map[string]interface{}, bool) {
values, ok := ctx.Value(contextValueKey).(map[string]interface{})
return values, ok
}
7 changes: 7 additions & 0 deletions trigger/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,13 @@ func (h *handlerImpl) Handle(ctx context.Context, triggerData interface{}) (resu
inputMap = triggerValues
}

// extract request parameters from trigger context, and make them available in actions
if reqParams, ok := ValuesFromContext(ctx); ok {
for k, v := range reqParams {
inputMap[k] = v
}
}

if ioMd := act.act.IOMetadata(); ioMd != nil {
for name, tv := range ioMd.Input {
if val, ok := inputMap[name]; ok {
Expand Down

0 comments on commit 4f85a3b

Please sign in to comment.