Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Height discrepancy for some inputs #323

Closed
cjhowald opened this issue Jan 23, 2017 · 6 comments
Closed

Height discrepancy for some inputs #323

cjhowald opened this issue Jan 23, 2017 · 6 comments
Assignees

Comments

@cjhowald
Copy link
Contributor

Some of the dress code inputs have a height of 22px. They should be 24px instead.

  • dc-select--small
  • dc-checkbox (note: dc-checkbox--alt is already 24px line height)
  • dc-radio
  • dc-btn--small

Also check the following, which might need to change to match:

  • dc-list__title
@cjhowald
Copy link
Contributor Author

@xonic here is the issue we discovered today.

@xonic xonic self-assigned this Jan 23, 2017
@gabrielhl
Copy link
Contributor

Good work, thanks for noticing this!

@gabrielhl gabrielhl added the bug label Jan 25, 2017
@gabrielhl gabrielhl self-assigned this Feb 8, 2017
@gabrielhl
Copy link
Contributor

I'm working on this. For now my approach will be to make the elements have a 24px height but keep the checkbox/radio/etc having 22px to not impact the UI visual.

@xonic
Copy link
Contributor

xonic commented Feb 15, 2017

screen shot 2017-02-15 at 16 00 14

@gabrielhl
Copy link
Contributor

gabrielhl commented Feb 20, 2017

Tracking my progress

  • dc-select--small
  • dc-checkbox
  • dc-radio
  • dc-btn--small
  • dc-list__title

gabrielhl pushed a commit that referenced this issue Feb 20, 2017
@gabrielhl gabrielhl changed the title Line height discrepancy for some inputs Height discrepancy for some inputs Feb 22, 2017
@gabrielhl
Copy link
Contributor

Change the title to make it clearer that this is related to the element's height, not line height

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants