This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
fix(style): Standardise elements height to 2.4rem #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gabrielhl in the issue you mention that you wanna keep the height of checkbox/radio etc. 22px but with the changes you made they're 24. Is that intended? .dc-btn--small is also mentioned to have 24 but has 12 |
|
@frontendherodk the height of the surrounding element is now 24 but the height of the box or circle stayed at 22. This is to keep the visual style intact for now, but allow an easier alignment of the elements. |
|
Ah. A little confusing from the issue description but all good then |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #323