Inline shellescape dependency #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Martin <williammartin@github.com>
williammartin
force-pushed
the
wm/inline-shellescape
branch
from
db0afbc
to
728c0fd
Compare
|
Let's put it under |
williammartin
force-pushed
the
wm/inline-shellescape
branch
from
2f5e281
to
3fa214d
Compare
Signed-off-by: William Martin <williammartin@github.com>
Signed-off-by: William Martin <williammartin@github.com>
williammartin
force-pushed
the
wm/inline-shellescape
branch
from
3fa214d
to
2b99802
Compare
|
Cool, I also uhh... remembered to actually use it. 😅 |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relates to the discussion in #113 about the
shellescapedependency using a vanity URL and practical solutions for avoiding that.From my point of view, the dependency is small and stable so the risk of inlining this is low. I understand if you'd prefer not to though.