routesrv: reuse skipper.Options #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2023
AlexanderYastrebov
force-pushed
the
routesrv/reuse-skipper-options
branch
3 times, most recently
from
47fa773
to
b3bb997
Compare
Reuse skipper.Options datastructure to avoid duplicate work of adding the same flags/options to both skipper and routesrv. Followup on #1873 Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
routesrv/reuse-skipper-options
branch
from
b3bb997
to
e294de2
Compare
|
👍 |
| @@ -891,6 +891,39 @@ type Options struct { | |||
| LuaSources []string | |||
| } | |||
|
|
|||
| func (o *Options) KubernetesDataClientOptions() kubernetes.Options { | |||
There was a problem hiding this comment.
Just one question here, is it better to have this as Options function or to send options reference?
There was a problem hiding this comment.
What do you see as an advantage to change it?
|
So, Skipper and Routesrv options set are completely identical, aren't they? |
|
👍 |
szuecs
reviewed
Jun 22, 2023
| @@ -21,7 +21,6 @@ import ( | |||
| "github.com/zalando/skipper/eskip" | |||
| "github.com/zalando/skipper/net" | |||
| "github.com/zalando/skipper/proxy" | |||
| routesrv "github.com/zalando/skipper/routesrv" | |||
|
👍 |
yes, but routesrv uses only subset of them. Note also that it parses all flags so you can run it with a flag that it does not use e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse skipper.Options datastructure to avoid duplicate work of adding
the same flags/options to both skipper and routesrv.
Followup on #1873
Signed-off-by: Alexander Yastrebov alexander.yastrebov@zalando.de