-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skipper: refactor test options #2417
Conversation
This would be used by #2416 |
c86ceeb
to
268b517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not expose channels in skipper library, because it is not a good api for library users and I don't see why we would need it.
We discussed that you can hopefully use export_test.go to expose an API to pass channels, if routesrv does it similar we can not use this to start both and then it's fine to pass it via Options. |
Remove unexported test options to allow using them outside of skipper package. * refactor testOptions into Options fields * add shutdown channels Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
268b517
to
928bab5
Compare
Currently there is no way to run skipper within the same process (e.g. from the test) and properly shutdown it because it only shuts down on SIGTERM. This change does not expose any internal channels but allows user to specify optional channels to trigger and signal shutdown. |
routesrv also does not support programmatic shutdown atm |
We need to think more about programmatic shutdown for both skipper and routesrv. Closing this for now in favor of #2419 |
Remove unexported test options to allow using them outside of skipper package.