skipper: fix TestDataClients #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AlexanderYastrebov
commented
Jun 21, 2023
•
AlexanderYastrebov
commented
- fix swarm init error handling
- remove TestDataClients invalid swarm options
1 task
Comment on lines
+1630
to
1636
| return fmt.Errorf("failed to init swarm with options %+v: %w", swops, err) | ||
| } | ||
| defer theSwarm.Leave() |
There was a problem hiding this comment.
run does not fail because here it only logged the error and later defer theSwarm.Leave() caused panic
| @@ -1026,21 +1026,23 @@ func TestDataClients(t *testing.T) { | |||
| sigs := make(chan os.Signal, 1) | |||
| go run(o, sigs, nil) | |||
|
|
|||
| // wait for proxy being ready | |||
| for { | |||
| for i := 0; i < 10; i++ { | |||
There was a problem hiding this comment.
After log is changed to return error proxy is never ready due to infinite wait
|
👍 |
* fix swarm init error handling * remove TestDataClients invalid swarm options Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov
force-pushed
the
skipper/fix-test-data-clients
branch
from
77bdc04
to
495d4fc
Compare
|
Pipeline failed due to #2386 |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.