Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: disable testcontainers Ryuk #2930

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

AlexanderYastrebov
Copy link
Member

@AlexanderYastrebov AlexanderYastrebov commented Feb 12, 2024

Disable reaper container for github builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk

Updates #2668
Updates #2621
Updates #2556

@AlexanderYastrebov AlexanderYastrebov added the minor no risk changes, for example new filters label Feb 12, 2024
Disable reaper container for github builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
@AlexanderYastrebov AlexanderYastrebov changed the title hithub: disable testcontainers Ryuk github: disable testcontainers Ryuk Feb 12, 2024
@szuecs
Copy link
Member

szuecs commented Feb 12, 2024

Same would need to be done in CDP (delivery.yaml) right?

@szuecs
Copy link
Member

szuecs commented Feb 12, 2024

👍

@AlexanderYastrebov
Copy link
Member Author

Same would need to be done in CDP (delivery.yaml) right?

I think we observe testcontainers related flakes mostly on github builders.
Lets see how this works out and then apply to CDP if necessary.

@AlexanderYastrebov
Copy link
Member Author

👍

@AlexanderYastrebov AlexanderYastrebov merged commit 6b9cfb9 into master Feb 12, 2024
14 checks passed
@AlexanderYastrebov AlexanderYastrebov deleted the github/disable-testcontainers-ryuk branch February 12, 2024 23:13
AlexanderYastrebov added a commit that referenced this pull request Feb 13, 2024
Disable reaper container for CDP builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk
and previous #2930

Updates #2668
Updates #2621
Updates #2556

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this pull request Feb 13, 2024
Disable reaper container for CDP builds.
This should hopefully eliminate testcontainer-related test flakes.

See https://golang.testcontainers.org/features/garbage_collector/#ryuk
and previous #2930

Updates #2668
Updates #2621
Updates #2556

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor no risk changes, for example new filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants