Add more tags to the admissionControl span to increase visibility #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanZavodskikh
added
do-not-merge
minor
|
I don't expect anything risky here, "do-not-merge" label is just to ensure this PR will be merged just after it will not be blocked by Zalando's deployment policy during Cyber Week. |
RomanZavodskikh
force-pushed
the
admissionControlSpanTags
branch
from
d41fc27 to
07da6ab
Compare
|
Can we rebase, remove the do-not-merge label and push this forward? |
RomanZavodskikh
force-pushed
the
admissionControlSpanTags
branch
from
07da6ab to
7289441
Compare
|
@MustafaSaber done. |
added 2 commits
December 17, 2024 11:09
Updates #3317 Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
Signed-off-by: Roman Zavodskikh <roman.zavodskikh@zalando.de>
RomanZavodskikh
force-pushed
the
admissionControlSpanTags
branch
from
7289441 to
aa6877c
Compare
|
👍 |
1 similar comment
|
👍 |
This was referenced Dec 17, 2024
MustafaSaber
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Dec 23, 2024
* zalando/skipper#3323 * zalando/skipper#3334 * zalando/skipper#3330 * zalando/skipper#3341 * zalando/skipper#3344 * zalando/skipper#3348 * zalando/skipper#3318 * zalando/skipper#3347 * zalando/skipper#3345 * zalando/skipper#3337 * zalando/skipper#3342 * zalando/skipper#3351 * zalando/skipper#3335 * zalando/skipper#3338 follow up on #8587 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3317